Conversation
- Create domain folders: Core/, Steps/, Packaging/, Examples/ - Move test files to appropriate domain folders - Create domain helper files: - Steps/_testHelpers.Steps.ps1 (contains New-IdleTestStepMetadata) - Providers/_testHelpers.Providers.ps1 (empty, ready for future use) - Update main _testHelpers.ps1 to dot-source domain helpers - Update all test file paths to use parent directory for helpers - All tests remain discoverable by Pester - PSScriptAnalyzer passes with no issues Co-authored-by: blindzero <13959569+blindzero@users.noreply.github.com>
|
@copilot Pester tests are red |
- Add missing IdLE.Steps.Mailbox module import to test helpers - Fix relative paths in Invoke-IdleStepAuthSession.Tests.ps1 (BeforeAll imports) - Fix relative paths in CapabilityDeprecation.Tests.ps1 (examples/workflows references) - Fix relative paths in ModuleSurface.Tests.ps1 (repoRoot calculation) - Tests now at 287 passed / 46 failed (was 247 passed / 87 failed) Co-authored-by: blindzero <13959569+blindzero@users.noreply.github.com>
- Fix fixtures paths in New-IdlePlan.Capabilities.Tests.ps1 - Fix fixtures paths in Export-IdlePlan.Tests.ps1 - Fix fixtures paths in Resolve-IdleStepMetadataCatalog.Tests.ps1 - Fix fixtures paths in Resolve-IdleWorkflowTemplates.Tests.ps1 - All tests now passing: 333 passed, 0 failed, 3 skipped - PSScriptAnalyzer passes with no issues Co-authored-by: blindzero <13959569+blindzero@users.noreply.github.com>
Fixed in commits 80e144f and b89a730. The test failures were caused by:
All 333 tests now pass with 0 failures. ✅ |
Add section describing the domain-organized test folder structure: - Core/, Steps/, Providers/, Packaging/, Examples/ folders - Test helper organization with single entry point - Fixture location This helps contributors understand where to place new tests. Co-authored-by: blindzero <13959569+blindzero@users.noreply.github.com>
PSSA status: ✅ Green (no blocking errors). There are 9 informational warnings about indentation in Documentation: ✅ Updated in commit 39999ba. Added a "Test folder structure" section to
This helps contributors understand where to place new tests. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
There was a problem hiding this comment.
Pull request overview
This PR reorganizes the test folder structure from a flat 29+ file layout into domain-specific folders, improving discoverability and maintainability. The helper functions are split by domain while maintaining a single stable entry point for all tests.
Changes:
- Restructured tests into domain-specific folders (Core, Steps, Providers, Packaging, Examples)
- Split test helper functions by domain with single entry point pattern
- Updated all test file paths to reference parent directory helper
- Added IdLE.Steps.Mailbox module import to shared test infrastructure
- Updated documentation to reflect new test organization
Reviewed changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/_testHelpers.ps1 | Dot-sources domain helpers at top; adds Mailbox module import; removes moved function |
| tests/Steps/_testHelpers.Steps.ps1 | New step-specific helper file containing New-IdleTestStepMetadata function |
| tests/Providers/_testHelpers.Providers.ps1 | New empty provider-specific helper file as extension point |
| tests/Steps/*.Tests.ps1 (6 files) | Updated to reference parent directory helper using Split-Path pattern |
| tests/Packaging/*.Tests.ps1 (4 files) | Updated helper references and repo root calculation for new location |
| tests/Examples/WorkflowSamples.Tests.ps1 | Updated helper reference for new location |
| tests/Core/*.Tests.ps1 (18 files) | Updated helper references and fixture paths for subdirectory structure |
| docs/advanced/testing.md | Documented new folder structure and helper organization |
Summary
Reorganized
tests/into domain-specific folders and split_testHelpers.ps1into domain helper files while maintaining a single stable entry point for all tests.Motivation
The flat
tests/structure had grown to 29+ files at the root level, making navigation difficult. Helper functions were centralized in one file regardless of domain. This restructure improves discoverability and maintainability without changing test behavior.Type of Change
Changes
Folder structure
Core/,Steps/,Packaging/,Examples/*.Tests.ps1and Pester-discoverableHelper split (single entry point preserved)
tests/Steps/_testHelpers.Steps.ps1- movedNew-IdleTestStepMetadatafrom global helpertests/Providers/_testHelpers.Providers.ps1- empty, ready for provider test infrastructuretests/_testHelpers.ps1to dot-source domain helpers at topIdLE.Steps.Mailboxmodule import to test helperstests/_testHelpers.ps1(single entry point maintained)Path updates and fixes
Join-Path (Split-Path -Path $PSScriptRoot -Parent) '_testHelpers.ps1'../to../../for moved files)Invoke-IdleStepAuthSession.Tests.ps1$PSScriptRootfor robust relative path resolutionDocumentation
docs/advanced/testing.mdwith new test folder structure sectionTesting
How to test & review
All 333 tests pass with 0 failures and 3 skipped. PSScriptAnalyzer passes with no blocking errors (9 pre-existing informational warnings unrelated to this change). The restructuring maintains full test coverage while improving organization.
Checklist
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.