Unify provider documentation structure across all providers#145
Unify provider documentation structure across all providers#145
Conversation
Co-authored-by: blindzero <13959569+blindzero@users.noreply.github.com>
Co-authored-by: blindzero <13959569+blindzero@users.noreply.github.com>
Co-authored-by: blindzero <13959569+blindzero@users.noreply.github.com>
Co-authored-by: blindzero <13959569+blindzero@users.noreply.github.com>
Co-authored-by: blindzero <13959569+blindzero@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 29a0c0a77e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Unifies the structure of provider reference pages under docs/reference/providers/ so all providers follow a consistent template-style layout (including a standardized Testing section) while retaining provider-specific details.
Changes:
- Restructured AD and Entra ID provider reference pages to align with the shared provider documentation template sections/order.
- Removed the repeated “Purpose” intro block from provider pages.
- Added a standardized “Testing” section (with unit test paths and CI notes) to all provider pages.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/reference/providers/provider-ad.md | Major restructure to template-style sections; adds operational/observability/testing content. |
| docs/reference/providers/provider-entraID.md | Major restructure to template-style sections; adds configuration/operational/observability/examples/testing content. |
| docs/reference/providers/provider-exchangeonline.md | Removes Purpose block; adds Testing section. |
| docs/reference/providers/provider-mock.md | Removes Purpose block; adds Testing section. |
| docs/reference/providers/provider-directorysync-entraconnect.md | Removes Purpose block; adds config parameters note and Testing section. |
Comments suppressed due to low confidence (2)
docs/reference/providers/provider-ad.md:184
- In the “Auth examples” section,
New-IdleAuthSessionis invoked with-DefaultCredential, but the actual parameter name is-DefaultAuthSession(seesrc/IdLE/Public/New-IdleAuthSession.ps1). As written, these examples will fail when copy/pasted; please update the parameter name in this section.
## Auth examples (Authentication patterns)
**A) Integrated authentication (no broker)**
```powershell
docs/reference/providers/provider-ad.md:144
- The Configuration section is currently mixing in authentication/session details (AuthSessionName/formats/options/AuthSessionType) that are already covered in the dedicated “Authentication and session acquisition” section earlier. To avoid duplication and future drift, keep auth/session details in the authentication section and limit Configuration to constructor/factory + provider map usage.
- **Auth session formats supported:**
- `null` (integrated authentication / run-as)
- `PSCredential` (used for AD cmdlets `-Credential`)
- **Session options (data-only):** Any hashtable; commonly `@{ Role = 'Tier0' }` / `@{ Role = 'Admin' }`
- **Required `AuthSessionType`:** `Credential`
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: blindzero <13959569+blindzero@users.noreply.github.com>
Provider Documentation Unification - COMPLETE ✅
Problem Statement
The dedicated provider documentation pages had structural inconsistencies. This PR unifies them to follow the same general structure while maintaining or improving quality and content coverage.
Analysis Summary
_provider-name_template.mddefines 11 mandatory sectionsChanges Implemented
✅ provider-ad.md
New-IdleAuthSessionexamples to use correct parameters (-DefaultAuthSessioninstead of-DefaultCredential)✅ provider-entraID.md
New-IdleAuthSessionexample to use correct parameters and AuthSessionType✅ provider-exchangeonline.md
✅ provider-mock.md
✅ provider-directorysync-entraconnect.md
Results
📊 Coverage Matrix
📈 Improvements
📝 Files Changed
provider-ad.md: +191, -84 lines (major restructure + fixes)provider-entraID.md: +194, -44 lines (major restructure + fixes)provider-exchangeonline.md: +7, -5 lines (Testing + Purpose removal)provider-mock.md: +7, -5 lines (Testing + Purpose removal)provider-directorysync-entraconnect.md: +14, -5 lines (Testing + Configuration + Purpose removal)Validation
New-IdleAuthSessionexamples use correct parameters✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.