Enforce strict path validation for precondition operators at execution time#245
Merged
blindzero merged 2 commits intocodex/create-task-branch-for-codex-merge-conflictfrom Feb 27, 2026
Conversation
Co-authored-by: blindzero <13959569+blindzero@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Reintegrate preconditions DSL branch and restore warning propagation
Enforce strict path validation for precondition operators at execution time
Feb 26, 2026
blindzero
approved these changes
Feb 26, 2026
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Code Coverage Report
|
7f973fb
into
codex/create-task-branch-for-codex-merge-conflict
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At plan time, missing
Request.Context.*paths in preconditions correctly emit a soft warning. At execution time however, missing paths silently evaluated tofalseviaTest-IdleCondition— swallowing misconfiguration as a valid precondition failure instead of throwing.Changes
Assert-IdleConditionPathsResolvable: Adds-ExcludeExistsOperatorPathsswitch. When set,Get-IdleConditionPathsskipsExists-operator paths during collection —Existssemantics are intentionally "does this path exist?", so a missing path should returnfalse, not error.Invoke-IdlePlanObject: Both the regular-step and OnFailure-step precondition blocks now callAssert-IdleConditionPathsResolvable -ExcludeExistsOperatorPathsbeforeTest-IdleCondition. Any non-Existspath missing from the execution context throws instead of silently evaluating.Tests: New fixture (
missing-context-at-invoke.psd1) and regression test verifying plan succeeds with a warning while execution throws with*unresolved condition path*.Behaviour matrix
New-IdlePlanRequest.Context.*→ soft warning; all others → hard errorInvoke-IdlePlanExistspath → throwsExistsoperatorfalseat any phase (unchanged)💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.