Fix precondition plan-time warning visibility and resolve PSSA CI alerts#246
Merged
blindzero merged 4 commits intocodex/create-task-branch-for-codex-merge-conflictfrom Feb 27, 2026
Conversation
- Add Write-Warning to Assert-IdleConditionPathsResolvable so missing Request.Context.* paths in preconditions emit a visible terminal warning during New-IdlePlan in addition to being stored in plan.Warnings - Rename Normalize-IdleExchangeOnlineAutoReplyMessage to Format-IdleExchangeOnlineAutoReplyMessage (PSUseApprovedVerbs) - Apply Invoke-Formatter to fix PSUseConsistentWhitespace and PSUseConsistentIndentation across 7 source files Co-authored-by: blindzero <13959569+blindzero@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Reintegrate preconditions DSL branch and restore warning propagation
Fix precondition plan-time warning visibility and resolve PSSA CI alerts
Feb 27, 2026
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
There was a problem hiding this comment.
Pull request overview
Improves operator feedback during plan-time precondition evaluation and cleans up PowerShell Script Analyzer (PSSA) violations across core/provider code to keep CI/code scanning clean.
Changes:
- Emit a visible
Write-Warningwhen precondition evaluation encounters plan-time-unresolvableRequest.Context.*paths (while still recording the warning inplan.Warnings). - Rename the Exchange Online private helper to an approved verb (
Normalize-*→Format-*) and update call sites + tests. - Apply formatting/whitespace fixes across multiple scripts to address PSSA indentation/whitespace rules.
Reviewed changes
Copilot reviewed 4 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Providers/ExchangeOnlineProvider.Tests.ps1 | Updates tests to call the renamed Format-IdleExchangeOnlineAutoReplyMessage. |
| src/IdLE.Provider.ExchangeOnline/Public/New-IdleExchangeOnlineProvider.ps1 | Updates Out-of-Office idempotency comparison to use the renamed formatting helper; includes large formatter-driven indentation changes. |
| src/IdLE.Provider.ExchangeOnline/Private/Format-IdleExchangeOnlineAutoReplyMessage.ps1 | Renames the private helper function and updates help examples accordingly. |
| src/IdLE.Provider.AD/Private/New-IdleADAdapter.ps1 | Formatter-driven whitespace/indentation cleanup. |
| src/IdLE.Provider.AD/Private/Get-IdleADAttributeContract.ps1 | Formatter-driven whitespace/indentation cleanup in contract hashtables. |
| src/IdLE.Core/Public/New-IdleRequestObject.ps1 | Formatter-driven alignment cleanup. |
| src/IdLE.Core/Public/New-IdleAuthSessionBroker.ps1 | Formatter-driven indentation cleanup in error detail construction. |
| src/IdLE.Core/Public/Invoke-IdlePlanObject.ps1 | Formatter-driven whitespace/indentation cleanup in a few expressions. |
| src/IdLE.Core/Private/Get-IdleReadOnlyCapabilities.ps1 | Minor switch formatting cleanup. |
| src/IdLE.Core/Private/Assert-IdleConditionPathsResolvable.ps1 | Adds host-visible Write-Warning for plan-time soft-missing Request.Context.* precondition paths and simplifies warning construction. |
src/IdLE.Provider.ExchangeOnline/Public/New-IdleExchangeOnlineProvider.ps1
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
blindzero
requested changes
Feb 27, 2026
src/IdLE.Provider.ExchangeOnline/Public/New-IdleExchangeOnlineProvider.ps1
Show resolved
Hide resolved
Code Coverage Report
|
- Re-apply Invoke-Formatter to New-IdleExchangeOnlineProvider.ps1 to produce zero PSUseConsistentIndentation violations (fixes #2865282671) - Fix Invoke-IdlePlanObject.ps1 line 121 continuation indent to match formatter expectation (no extra 4 spaces on the -or continuation) - Update ExchangeOnlineProvider.Tests.ps1 BeforeAll: rename variable $normalizeFunctionPath -> $formatHelperPath to match file name, and clarify comment with consistent normalization/format terminology Co-authored-by: blindzero <13959569+blindzero@users.noreply.github.com>
blindzero
approved these changes
Feb 27, 2026
blindzero
merged commit 1fefe8c
into
codex/create-task-branch-for-codex-merge-conflict
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.