Fix PSSA indentation, add per-step export warnings, beautify PSSA tool output#247
Merged
blindzero merged 3 commits intocodex/create-task-branch-for-codex-merge-conflictfrom Feb 27, 2026
Conversation
…output Co-authored-by: blindzero <13959569+blindzero@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP Address feedback on PSSA warnings and JSON format
Fix PSSA indentation, add per-step export warnings, beautify PSSA tool output
Feb 27, 2026
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates IdLE’s ExchangeOnline provider and plan export contract to satisfy PSScriptAnalyzer indentation rules, propagate step-level planning warnings into the exported JSON, and improve the ergonomics of the local PSScriptAnalyzer tool output.
Changes:
- Refactors
EnsureMailboxPermissionspipelines to avoid PSSA indentation false positives and normalizes block indentation. - Extends plan export mapping and fixture to include per-step
warningsarrays, with test assertions added. - Adds formatted, color-coded header/finding/summary output to
Invoke-IdleScriptAnalyzer.ps1.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/Invoke-IdleScriptAnalyzer.ps1 | Adds Write-PssaHeader/Finding/Summary helpers and prints findings + summary with clearer formatting. |
| src/IdLE.Provider.ExchangeOnline/Public/New-IdleExchangeOnlineProvider.ps1 | Adjusts indentation/pipeline structure in EnsureMailboxPermissions to satisfy PSSA rules. |
| src/IdLE.Core/Private/ConvertTo-IdlePlanExportObject.ps1 | Adds warnings export on each step by serializing step warning objects into the plan-export contract shape. |
| tests/fixtures/plan-export/expected/plan-export.json | Updates expected export fixture to include per-step "warnings": []. |
| tests/Core/Export-IdlePlan.Tests.ps1 | Extends warning export test to assert step-level warning presence/code in exported JSON. |
blindzero
requested changes
Feb 27, 2026
Co-authored-by: blindzero <13959569+blindzero@users.noreply.github.com>
Code Coverage Report
|
blindzero
approved these changes
Feb 27, 2026
blindzero
merged commit cb8a81f
into
codex/create-task-branch-for-codex-merge-conflict
8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EnsureMailboxPermissionsConvertTo-IdlePlanExportObject.ps1, fixture, tests)Invoke-IdleScriptAnalyzer.ps1output@($null).Countassertion — replaced withShould -Not -BeNullOrEmpty+Measure-Objectcount so a missing/nullwarningsarray correctly fails the test🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.