fix: warn when session cookie secret is not configured#935
Merged
Conversation
Member
Author
|
@jeremydw here's a PR for that issue you were debugging earlier today. |
Member
|
LGTM but i think this will appear in the deployed app logs (and not locally in dev mode due to https://github.com/blinkk/rootjs/pull/895/changes) - is that right? if so maybe we need to log something more prominently since, at least in cloud console's logs viewer, it might be hard to spot that |
Member
Author
|
it checks the root.config.ts setting explicitly so it should appear in dev afaict |
Member
|
ah right - of course. sounds good. this is a good temp fix - we may still want to show a "setup error" on the CMS login page though if it's not configured (to prevent the eng from having to check the logs on first setup) |
Member
Author
|
agreed, let me work on a warning box for that in a follow-up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
server.sessionCookieSecretis not configured so they know sessions may be invalidated across server restarts.Description
hasWarnedMissingSessionCookieSecretand a check inres.saveSession()that logs aconsole.warnwhenreq.rootConfig?.server?.sessionCookieSecretis not set; change is inpackages/root/src/middleware/session.ts.Testing
Codex Task