fix: exclude keys for non-matching domains on lookup

[agaffney]

Summary by cubic

Fixes record lookup to return only entries for the requested domain by skipping keys with non-numeric suffixes. Prevents cross-domain collisions when different domains share the same prefix.

• Bug Fixes
  • In lookupRecords, ignore keys where the suffix after keyPrefix isn’t purely numeric (strconv.Atoi fails), ensuring we don’t include records from other domains.

^{Written for commit 69011ed. Summary will update automatically on new commits.}

Summary by CodeRabbit

• Bug Fixes
  • Improved record lookup validation to ensure only properly formatted records are processed during retrieval operations, enhancing system stability and data integrity.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

The LookupRecords function in internal/state/state.go now includes filtering logic to skip keys with non-numeric suffixes when iterating over records with a given key prefix. Only keys whose suffix (the portion after the prefix) contains purely numeric characters proceed to value decoding into DomainRecord. No modifications to control flow, error handling, or exported APIs are present.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• The filtering logic is localized to a single function and straightforward in nature
• Reviewers should verify the numeric validation criteria aligns with intended data structure expectations
• Confirm no edge cases or key formats are inadvertently excluded by the filter

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title describes filtering out non-matching keys during domain lookup, which aligns with the actual change of filtering keys with non-numeric suffixes in the LookupRecords function.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/db-lookup-prefix

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 20434fc and 69011ed.

📒 Files selected for processing (1)

• internal/state/state.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: cubic · AI code reviewer
• GitHub Check: Analyze (go)

🔇 Additional comments (1)

internal/state/state.go (1)

339-344: Fix for DNS prefix matching bug confirmed.

The numeric suffix validation correctly filters unrelated domain records. When looking up records for "example", the prefix r_A_example_ previously matched both r_A_example_0 (correct) and r_A_example.com_0 (incorrect). The fix ensures only valid record indices are accepted.

The implementation is solid:

• Suffix extraction is safe because ValidForPrefix guarantees the key starts with the prefix
• strconv.Atoi correctly rejects non-numeric suffixes like ".com_0"
• Malformed or empty suffixes are properly skipped

Verify that test coverage exists for domain lookup scenarios with overlapping name prefixes to prevent regression.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cubic-dev-ai]

No issues found across 1 file