feat: configurable validation of historical blocks in ledger #671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agaffney
force-pushed
the
feat/historical-validation
branch
from
2e4f2dd to
2691fad
Compare
This disables validation of "historical" (more than 2 weeks old) blocks and transactions by default Signed-off-by: Aurora Gaffney <aurora@blinklabs.io>
agaffney
force-pushed
the
feat/historical-validation
branch
from
2691fad to
2ecab09
Compare
wolf31o2
approved these changes
May 1, 2025
| cleanupConsumedUtxosInterval = 5 * time.Minute | ||
| cleanupConsumedUtxosSlotWindow = 50000 // TODO: calculate this from params (#395) | ||
|
|
||
| validateHistoricalThreshold = 14 * (24 * time.Hour) // 2 weeks |
Member
There was a problem hiding this comment.
Stick a TODO/issue for making this configurable, please.
Member
|
One comment, but it's OK to add it in another PR after you make the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables validation of "historical" (more than 2 weeks old) blocks and transactions by default