Skip to content

feat(database): Support storing/retrieving Datums by hash #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 12, 2025
Merged

feat(database): Support storing/retrieving Datums by hash #685

merged 3 commits into from
May 12, 2025

Conversation

@arepala-uml
Copy link
Contributor

@arepala-uml arepala-uml commented May 5, 2025

  1. Added datum struct in modesl/datum.go.
  2. Implemented GetDatum and SetDatum methods in sqlite/datum.go.
  3. Added Datum in the MigrateModels to ensure DB migrations apply correctly for this table.
  4. Updated the MetadataStore interface with GetDatum, SetDatum methods.
  5. Added Top-level database methods GetDatumByHash and SetDatumByHash.

Closes #317

@arepala-uml
feat(database): Added support for storing and retrieving datums by hash
b4dba8f 
Signed-off-by: Akhil Repala <arepala@blinklabs.io>
@arepala-uml arepala-uml marked this pull request as ready for review May 5, 2025 03:00
@arepala-uml arepala-uml requested a review from a team as a code owner May 5, 2025 03:00
@arepala-uml arepala-uml requested review from agaffney and wolf31o2 May 5, 2025 03:00
agaffney
agaffney requested changes May 5, 2025
View reviewed changes
wolf31o2
wolf31o2 requested changes May 5, 2025
View reviewed changes
Copy link
Member

@wolf31o2 wolf31o2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor changes to keep things more in line with the other functions.

@arepala-uml
feat(database): Addressed all the comments in the PR and modified all…
5230389 
… the things

Signed-off-by: Akhil Repala <arepala@blinklabs.io>
@arepala-uml arepala-uml requested review from agaffney and wolf31o2 May 10, 2025 18:52
@arepala-uml
fix(database): Formatted metadataStore interface correctly to satisfy…
c8f0a13 
… with gofumpt linter rules

Signed-off-by: Akhil Repala <arepala@blinklabs.io>
@wolf31o2 wolf31o2 merged commit 63a26f0 into main May 12, 2025
10 checks passed
@wolf31o2 wolf31o2 deleted the dataums_hash branch May 12, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolf31o2 wolf31o2 wolf31o2 approved these changes

@agaffney agaffney agaffney approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support storing/retrieving Datums by hash

4 participants

@arepala-uml @wolf31o2 @agaffney