Skip to content

fix: don't send more than requested TxIds count #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2025
Merged

fix: don't send more than requested TxIds count #766

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions txsubmission.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,11 @@ func (n *Node) txsubmissionClientRequestTxIds(
// Get available TXs
var tmpTxs []*mempool.MempoolTransaction
for {
// nolint:staticcheck
// The linter wants to move this up into the loop condition, but it's more readable this way
if len(tmpTxs) >= int(req) {
break
}
if blocking && len(tmpTxs) == 0 {
// Wait until we see a TX
tmpTx := consumer.NextTx(true)
Expand Down
Loading