chore(deps): gouroboros 0.138.0

[wolf31o2]

Summary by CodeRabbit

• Refactor

  • Improved internal type safety for pool key handling across database and ledger operations.

• Chores

  • Updated dependency library to version 0.138.0 for enhanced library functionality.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request updates the pool key hash parameter type across multiple database and ledger-related files. The GetPool method signature in database interfaces and implementations changes from accepting []byte to lcommon.PoolKeyHash. Call sites in SetPoolRegistration and SetPoolRetirement are updated to wrap byte slices with the new type. An import alias for lcommon is added where needed. The external dependency gouroboros is upgraded from v0.137.1 to v0.138.0.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Verify all call sites wrapping byte slices with lcommon.PoolKeyHash are correctly applied (SetPoolRegistration, SetPoolRetirement)
• Confirm the dependency upgrade to v0.138.0 is compatible and introduces the PoolKeyHash type
• Check for any additional call sites of GetPool outside the shown diff that may require updating

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title indicates a dependency upgrade to gouroboros 0.138.0, which aligns with the go.mod change and the cascading API updates throughout the codebase to accommodate the new PoolKeyHash type from the upgraded dependency.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chore/gouroboros-0.138.0

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 918d38b and 24b891c.

⛔ Files ignored due to path filters (1)

• go.sum is excluded by !**/*.sum

📒 Files selected for processing (5)

• database/plugin/metadata/sqlite/pool.go (4 hunks)
• database/plugin/metadata/store.go (1 hunks)
• database/pool.go (1 hunks)
• go.mod (1 hunks)
• ledger/view.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)

• GitHub Check: docker (ubuntu-latest, amd64)
• GitHub Check: lint
• GitHub Check: nilaway
• GitHub Check: go-test (1.24.x, ubuntu-latest)
• GitHub Check: go-test (1.25.x, ubuntu-latest)
• GitHub Check: go-test (1.24.x, macos-latest)
• GitHub Check: go-test (1.25.x, macos-latest)
• GitHub Check: Analyze (go)

🔇 Additional comments (9)

ledger/view.go (1)

82-84: LGTM! Type-safe signature improvement.

The parameter type change from []byte to lcommon.PoolKeyHash adds semantic clarity and type safety to the API.

database/pool.go (2)

19-19: LGTM! Import added for type-safe parameter.

The import alias enables the use of lcommon.PoolKeyHash in the function signature.

---

23-26: LGTM! Signature updated for type safety.

The parameter type change from []byte to lcommon.PoolKeyHash is consistent with the interface and implementation updates.

database/plugin/metadata/store.go (1)

47-50: LGTM! Interface signature updated consistently.

The interface method signature update to accept lcommon.PoolKeyHash is consistent with the implementation and maintains API clarity.

database/plugin/metadata/sqlite/pool.go (4)

28-31: LGTM! Signature updated for type safety.

The parameter type change from []byte to lcommon.PoolKeyHash implements the updated interface.

---

41-45: LGTM! Correct conversion for database query.

The .Bytes() method correctly converts the PoolKeyHash to []byte for the SQL query parameter.

---

222-222: LGTM! Call site correctly updated.

The call site properly wraps cert.PoolKeyHash[:] with lcommon.PoolKeyHash to match the updated GetPool signature.

---

149-149: LGTM! All GetPool call sites correctly updated.

Verification confirms that all call sites properly pass arguments as lcommon.PoolKeyHash type:

• Line 149 (database/plugin/metadata/sqlite/pool.go): wraps cert.Operator[:] with lcommon.PoolKeyHash()
• Line 222 (database/plugin/metadata/sqlite/pool.go): wraps cert.PoolKeyHash[:] with lcommon.PoolKeyHash()
• Line 31 (database/pool.go) & Line 85 (ledger/view.go): pass pre-typed lcommon.PoolKeyHash parameters

No breaking changes detected.

go.mod (1)

12-12: Dependency update verified—version exists with no security advisories.

The upgrade to v0.138.0 is confirmed as a valid release with no reported security vulnerabilities.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}