Skip to content

Conversation

@wolf31o2
Copy link
Member

@wolf31o2 wolf31o2 commented Nov 21, 2025


Summary by cubic

Update Dockerfile to build cardano-node 10.5.3 instead of 10.5.2, and bump the build base image to ghcr.io/blinklabs-io/haskell:9.6.6-3.12.1.0-3. Switch CI and publish workflows to self-hosted Linux X64 (ansible) runners for AMD64 builds.

Written for commit 09e0614. Summary will update automatically on new commits.

Summary by CodeRabbit

  • Chores
    • Updated the build environment base image to a newer patch release and bumped the Node.js patch version to improve stability and compatibility during builds.
  • CI
    • Switched CI job runners from the hosted default to self‑hosted Linux x86_64 runners to align build execution with on‑premise infrastructure and runner requirements.

✏️ Tip: You can customize this high-level summary in your review settings.

@wolf31o2 wolf31o2 requested review from a team as code owners November 21, 2025 16:21
@coderabbitai
Copy link

coderabbitai bot commented Nov 21, 2025

📝 Walkthrough

Walkthrough

The Dockerfile updates the base image tag from ghcr.io/blinklabs-io/haskell:9.6.6-3.12.1.0-2 to ghcr.io/blinklabs-io/haskell:9.6.6-3.12.1.0-3 and bumps ARG NODE_VERSION from 10.5.2 to 10.5.3. Two GitHub Actions workflows (.github/workflows/ci-docker.yml and .github/workflows/publish.yml) change their runner selection from runs-on: ubuntu-latest to runs-on: [self-hosted, Linux, X64, ansible]. No other build steps, environment variables, or exported/public declarations were modified.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Mixed changes: simple version bumps in Dockerfile and runner label changes in two CI workflows.
  • Files to inspect:
    • Dockerfile — confirm ARG/ENV consistency and rebuild expectations.
    • .github/workflows/ci-docker.yml — verify self-hosted runner labels and any runner-specific assumptions.
    • .github/workflows/publish.yml — same runner-label verification for publish pipeline.

Possibly related PRs

  • feat: cardano-node 10.5.2 #301: Previously bumped NODE_VERSION in the same Dockerfile (10.5.1 → 10.5.2), indicating sequential node version updates.
  • ci: change runners #303: Modified GitHub Actions workflow runner specifications, related to the runner label changes in this PR.

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat: cardano-node 10.5.3' accurately reflects the main change: updating cardano-node from 10.5.2 to 10.5.3, which is the primary functional update in the Dockerfile.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/cardano-node-10.5.3

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4013d34 and 09e0614.

📒 Files selected for processing (3)
  • .github/workflows/ci-docker.yml (1 hunks)
  • .github/workflows/publish.yml (1 hunks)
  • Dockerfile (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • .github/workflows/publish.yml
  • .github/workflows/ci-docker.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build-arm64
  • GitHub Check: build-amd64
🔇 Additional comments (3)
Dockerfile (3)

3-3: Verified: cardano-node 10.5.3 tag exists and is valid upstream.

The tag 10.5.3 exists in the cardano-node repository (now at IntersectMBO/cardano-node after a repository transfer) and points to a valid commit. The version bump from 10.5.2 to 10.5.3 is legitimate and the git tag checkout in the Dockerfile will work as intended.


1-1: Cardano-node 10.5.3 is a valid, critical bugfix release released today (Nov 21, 2025).

The cardano-node version bump to 10.5.3 is verified and recommended—this release addresses hash size issues and a critical networking deficiency in the peer selection mechanism. The release notes state that all users on versions 10.3.1 through 10.5.1 must upgrade promptly.

The base image tag 9.6.6-3.12.1.0-3 cannot be verified via public APIs due to private registry authentication, but this is expected. The CI workflow does not explicitly authenticate before pulling the base image, suggesting your self-hosted runners have credentials pre-configured. If the image were unavailable, the build would fail at the pull step. The version is compatible: both require GHC 9.6 and Cabal 3.8/3.12.

No code issues found.


1-1: I found initial information about cardano-node 10.5.3 release details. Now I need to verify the GHC/Haskell compatibility requirements. Let me search for more specific build requirements:

I found important information about GHC compatibility. Let me search for more specifics about the 9.6.6 vs 9.6.7 difference:

Let me search for the specific Docker image to verify its contents:

Based on my research, I can now provide the rewritten review comment:


Verify GHC patch version compatibility with cardano-node 10.5.3.

For cardano-node 10.5.1, the recommended GHC version is 9.6.7 and Cabal 3.12.1.0. The Dockerfile specifies GHC 9.6.6, which is a patch-level difference. GHC 9.6.7 includes critical fixes: the internal Unique type has been widened to 64-bits on 32-bit architectures (avoiding potential miscompilations on large projects), and it fixes a runtime crash when using the compacting GC with black holes in large objects. The blinklabs-io/haskell image is specifically designed for developing Haskell applications for Cardano, making it appropriate for this use case, but consider whether the specific patch version 9.6.6 provides sufficient compatibility or if upgrading to 9.6.7 is necessary. cardano-node 10.5.x dropped GHC 8.10 support, confirming that GHC 9.6.x is required.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

verbotenj
verbotenj previously approved these changes Nov 21, 2025
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

agaffney
agaffney previously approved these changes Nov 21, 2025
Signed-off-by: Chris Gianelloni <wolf31o2@blinklabs.io>
@wolf31o2 wolf31o2 force-pushed the feat/cardano-node-10.5.3 branch from 4013d34 to 09e0614 Compare November 21, 2025 19:14
@wolf31o2 wolf31o2 merged commit 1f97ad6 into main Nov 21, 2025
7 checks passed
@wolf31o2 wolf31o2 deleted the feat/cardano-node-10.5.3 branch November 21, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants