fix(ci-docker): switch to GitHub Actions cache to prevent runner disk… #304

rezarajan · 2025-11-21T18:49:39Z

Changelog

switch to GitHub Actions cache to prevent runner disk exhaustion
refactor to use a matrix strategy for both amd64 and arm64
remove qemu (Remove QEMU #300)

Summary by cubic

Switched the Docker CI workflow to GitHub Actions cache to prevent runner disk exhaustion and simplified multi-arch builds. Replaced duplicate jobs with a single matrix for amd64 and arm64, removing QEMU by using a native arm64 runner.

Bug Fixes
- Use cache-from/to: type=gha to move buildx cache off the runner disk.
- Scope buildx caches per arch to avoid overwrites.
Refactors
- Combine separate jobs into a matrix (amd64, arm64) with arch-specific runners.
- Remove QEMU; build arm64 on ubuntu-24.04-arm.
- Pin all actions to commit SHAs.
- Standardize image tag suffixes via docker/metadata-action.

^{Written for commit 7ab77a9. Summary will update automatically on new commits.}

Summary by CodeRabbit

Chores
- Consolidated architecture-specific CI jobs into a unified matrix-driven build.
- Added conditional runner selection per architecture and a dedicated Docker build step.
- Improved caching strategy for faster, more reliable builds and removed redundant cache steps.
- Retained image metadata and build/push behavior while simplifying workflow configuration.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

… exhaustion - refactor to use a matrix strategy for both amd64 and arm64 - remove qemu (blinklabs-io#300) Signed-off-by: Reza Rajan <28660160+rezarajan@users.noreply.github.com>

coderabbitai · 2025-11-21T18:49:46Z

📝 Walkthrough

Walkthrough

Consolidates separate amd64 and arm64 CI Docker jobs into a single matrix-driven job over arch [amd64, arm64]. Replaces fixed runner with a conditional selection (uses ubuntu-24.04-arm for arm64, ubuntu-latest otherwise). Removes explicit QEMU and per-arch local-cache setup; switches build cache to GitHub Actions cache (cache-from/type=gha, cache-to/type=gha,mode=max) scoped by buildkit-${{ matrix.arch }}. Computes image suffix via matrix expression (-arm64v8 for arm64, -amd64 for amd64) and adds a new "Build Docker image" step prior to build-push, preserving metadata/labels usage.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Verify matrix job produces identical artifacts for both architectures and that the suffix expression is correct.
Confirm conditional runner expression evaluates as intended and that ubuntu-24.04-arm is available when required.
Review cache scope naming (buildkit-${{ matrix.arch }}) and type=gha usage for correctness and expected cache reuse.
Check the new "Build Docker image" step integrates with the metadata action and does not duplicate labels/tags.
Ensure removal of explicit QEMU and per-arch cache steps does not break cross-arch builds.

Files/areas to pay extra attention to:

.github/workflows/ci-docker.yml — matrix, runner condition, cache configuration, and new step interactions.

Possibly related PRs

feat: cardano-node 10.5.3 #302 — Also modifies .github/workflows/ci-docker.yml, changing runner selection and build-job configuration; overlaps on CI job structure.
ci: change runners #303 — Alters runner selection/configuration in the same workflow file; related to runner assignment changes.

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly captures the main objective of switching to GitHub Actions cache to prevent runner disk exhaustion, which aligns with the primary change in the changeset.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

rezarajan · 2025-11-21T18:52:31Z

Testing out the ci-docker workflow before making any changes to the publish workflow.

Signed-off-by: Reza Rajan <28660160+rezarajan@users.noreply.github.com>

.github/workflows/ci-docker.yml

Signed-off-by: Reza Rajan <28660160+rezarajan@users.noreply.github.com>

rezarajan · 2025-11-21T19:42:04Z

CI builds with the gha cache finished ✅

rezarajan · 2025-11-21T19:51:21Z

Issue

While the GHA cache works, and can be used in future runs, the last finished build in the pipeline will overwrite the cache since it does not have any unique references (arch, build target/tags).

See [Docker Docs on gha cache] (https://docs.docker.com/build/cache/backends/gha/#scope).

Scope is a key used to identify the cache object. By default, it is set to buildkit. If you build multiple images, each build will overwrite the cache of the previous, leaving only the final cache.

TODO: Include scope for cache to avoid overwriting.

wolf31o2

Breaking the per-architecture caches is not acceptable. This is why we don't use the gha cache type. It cannot support the proper cache necessary to cache both builds. Having an unpredictable cache is not the answer here.

cubic-dev-ai

No issues found across 1 file

Signed-off-by: Reza Rajan <28660160+rezarajan@users.noreply.github.com>

rezarajan · 2025-11-21T20:45:41Z

Breaking the per-architecture caches is not acceptable. This is why we don't use the gha cache type. It cannot support the proper cache necessary to cache both builds. Having an unpredictable cache is not the answer here.

Agreed. I am testing out a new build with scoped caches (see updated comment). This should avoid per-architecture overwrites.

To preserve the cache for multiple builds, you can specify this scope attribute with a specific name.

For this I have opted to use the pattern buildkit-<arch>, which should preserve cache for each architecture defined in the matrix.

Signed-off-by: Reza Rajan <28660160+rezarajan@users.noreply.github.com>

cubic-dev-ai

No issues found across 1 file

rezarajan · 2025-11-21T22:13:43Z

@wolf31o2 please review - this should work but needs to be tested with a workflow run to validate.

wolf31o2 · 2025-11-21T22:46:49Z

I started them back up. I cancelled your earlier runs because I was trying to get 10.5.3 built and needed the available runner slots.

rezarajan · 2025-11-22T02:19:12Z

@wolf31o2 the build succeeded; can you re-run the same workflow to check if the cache hits?

rezarajan · 2025-11-22T03:59:10Z

@wolf31o2 looks like cache works! Builds run in a few seconds. Do you want to merge this for now? The publish workflow can perhaps be updated later in another PR with a similar strategy.

wolf31o2 · 2025-11-22T22:33:14Z

I ran it again just for fun and it's so fast. Thank you.

cubic-dev-ai

No issues found across 1 file

fix(ci-docker): switch to GitHub Actions cache to prevent runner disk…

c52a761

… exhaustion - refactor to use a matrix strategy for both amd64 and arm64 - remove qemu (blinklabs-io#300) Signed-off-by: Reza Rajan <28660160+rezarajan@users.noreply.github.com>

refactor(ci-workflow): remove QEMU for native architecture builds

9f6508b

Signed-off-by: Reza Rajan <28660160+rezarajan@users.noreply.github.com>

wolf31o2 requested changes Nov 21, 2025

View reviewed changes

.github/workflows/ci-docker.yml Outdated Show resolved Hide resolved

.github/workflows/ci-docker.yml Outdated Show resolved Hide resolved

.github/workflows/ci-docker.yml Outdated Show resolved Hide resolved

.github/workflows/ci-docker.yml Outdated Show resolved Hide resolved

rezarajan added 2 commits November 21, 2025 15:36

fix(ci-docker): pin all actions to specific commit hashes

ddcb262

Signed-off-by: Reza Rajan <28660160+rezarajan@users.noreply.github.com>

Merge branch 'main' into ci/cachefix

2d9f4c8

Signed-off-by: Reza Rajan <28660160+rezarajan@users.noreply.github.com>

rezarajan force-pushed the ci/cachefix branch 5 times, most recently from 8cadc55 to 2d9f4c8 Compare November 21, 2025 20:16

rezarajan marked this pull request as ready for review November 21, 2025 20:18

rezarajan requested review from a team as code owners November 21, 2025 20:18

wolf31o2 requested changes Nov 21, 2025

View reviewed changes

cubic-dev-ai bot reviewed Nov 21, 2025

View reviewed changes

feat(ci-docker): use scoped cache names to avoid overwrites

f5f2ac0

Signed-off-by: Reza Rajan <28660160+rezarajan@users.noreply.github.com>

Merge branch 'main' into ci/cachefix

7ab77a9

Signed-off-by: Reza Rajan <28660160+rezarajan@users.noreply.github.com>

cubic-dev-ai bot reviewed Nov 21, 2025

View reviewed changes

rezarajan requested a review from wolf31o2 November 21, 2025 22:08

rezarajan marked this pull request as draft November 21, 2025 22:12

wolf31o2 marked this pull request as ready for review November 22, 2025 22:32

wolf31o2 approved these changes Nov 22, 2025

View reviewed changes

wolf31o2 merged commit 69f30b9 into blinklabs-io:main Nov 22, 2025
10 of 12 checks passed

cubic-dev-ai bot reviewed Nov 22, 2025

View reviewed changes

fix(ci-docker): switch to GitHub Actions cache to prevent runner disk… #304

fix(ci-docker): switch to GitHub Actions cache to prevent runner disk… #304

Conversation

rezarajan commented Nov 21, 2025 • edited by cubic-dev-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Summary by cubic

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Possibly related PRs

Pre-merge checks and finishing touches

Uh oh!

rezarajan commented Nov 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rezarajan commented Nov 21, 2025

Uh oh!

rezarajan commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue

Uh oh!

wolf31o2 left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

rezarajan commented Nov 21, 2025

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

rezarajan commented Nov 21, 2025

Uh oh!

wolf31o2 commented Nov 21, 2025

Uh oh!

rezarajan commented Nov 22, 2025

Uh oh!

rezarajan commented Nov 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wolf31o2 commented Nov 22, 2025

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rezarajan commented Nov 21, 2025 •

edited by cubic-dev-ai bot

Loading

coderabbitai bot commented Nov 21, 2025 •

edited

Loading

rezarajan commented Nov 21, 2025 •

edited

Loading

rezarajan commented Nov 22, 2025 •

edited

Loading