Merged
Conversation
Fixed bug where % symbols in gemtext are interpreted as printf escape codes. Also removed unneeded shellcheck directive.
Owner
|
Will take a look today. Thanks |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed a bug where
%symbols in gemtext are interpreted asprintfescape codes, due to the gemtext content being directly inserted into theprintfformat string. I also removed an unneeded ShellCheck directive.I can't find in the man pages etc. precisely how arguments work for
printf. It appears that--does what it usually does, in that it says that future arguments should not be treated as option flags, even if they start with-. What I'm not sure about is if arguments that start with-, but occur after the format string, get treated as options byprintf. Testing on theprintfs I have at hand (BusyBox'ssh, GNU coreutils'printf), they seem to not treat arguments after the format string that start with-as options. If this is indeed the standard, universally reliable behaviour, then the--in the linecan be removed. Due to my uncertainty, I haven't done this in this commit.