refactor: fold BreadcrumbSource into KNOWN_AGENTS#4
Merged
baldawarishi merged 3 commits intoblock:mainfrom Feb 13, 2026
Merged
Conversation
Move breadcrumb_dir and breadcrumb_ext fields directly into the Agent struct, eliminating the separate BreadcrumbSource struct and SOURCES constant. This makes it easier to add breadcrumb support for new agents by keeping all agent metadata in one place. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
baldawarishi
commented
Feb 12, 2026
Comment on lines
+86
to
+87
| breadcrumb_dir: None, | ||
| breadcrumb_ext: None, |
Collaborator
Author
There was a problem hiding this comment.
can also make None default to remove these, but I suspect we'd be able to fill most of these in, so left them as is for now.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
Also skipped version bump as v0.3.0 isn't released yet. |
alecthomas
approved these changes
Feb 12, 2026
Comment on lines
+86
to
+87
| breadcrumb_dir: None, | ||
| breadcrumb_ext: None, |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
|
@baldawarishi bumped to v0.3.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
breadcrumb_dirandbreadcrumb_extfields directly into theAgentstruct, eliminating the separateBreadcrumbSourcestruct andSOURCESconstantfind_agent()helper that matched agents by email prefix — no longer needed since we iterateKNOWN_AGENTSdirectlyAddresses #3 (comment)
Test plan
cargo test— all 16 tests pass./scripts/aittributor --debug— breadcrumb fallback still works correctly🤖 Generated with Claude Code