generated from block/oss-project-template
-
Notifications
You must be signed in to change notification settings - Fork 5
feat: add PR/branch picker to project creation form #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
72ae93d
feat: add PR or branch picker to project creation form
matt2e 31df2e4
fix: start worktree from remote tracking branch when it exists
matt2e 83d9445
feat: derive project name from selected PR or branch
matt2e 0152f74
feat: show 'New branch' badge when typed branch has no remote match
matt2e e0ee552
feat: show matched PR info in branch picker and save PR on project cr…
matt2e f2d9398
feat: extract PR and branch info from pasted GitHub URLs
matt2e 4655a06
feat: allow pasting GitHub URLs into the project name field
matt2e b3817ad
feat: support GitHub PR and branch URL pasting in Add Repo picker
matt2e 5d2c56e
fix: allow too_many_arguments for add_project_repo functions
matt2e 7f4d558
refactor: consolidate RepoSelection type into shared/githubUrl.ts
matt2e 0f0a562
fix: import RepoSelection types from source module instead of Svelte …
matt2e 0b29cbf
fix: resolve code review comments on PR/branch picker feature
matt2e 8686768
fix: defocus text fields after pasting a GitHub URL in project dialog
matt2e 4597dac
fix: start worktree from remote tracking branch in setup_worktree tau…
matt2e File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -589,6 +589,7 @@ impl ProjectToolsHandler { | |
| p.subpath, | ||
| None, | ||
| p.reason, | ||
| None, | ||
| ) | ||
| .await | ||
| { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For PR-backed branches whose head is not on
origin(notably fork PRs),remote_branch_existsis false and this path falls back tobranch.base_branch, so the created worktree starts from base instead of the selected PR commits. Since project creation now storespr_number, this produces projects that claim to target a PR but are checked out to unrelated code in this scenario.Useful? React with 👍 / 👎.