fix(ui): hide session button on pending timeline items#428
Conversation
The session button was showing on pending items before the session was fully ready, resulting in a non-functional button. Stop passing sessionId to TimelineRow for pending items so the button only appears once the item transitions to a real timeline entry with proper click handlers. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
builderbot/apps/staged/src/lib/features/timeline/BranchTimeline.svelte
Lines 491 to 495 in 010fc83
Keep pending placeholders wired to the live session modal
startBranchSessionWithPendingItem() writes the real sessionId onto these placeholder rows before the timeline has caught up (apps/staged/src/lib/features/branches/BranchCardSessionManager.svelte.ts:183-221). Pending rows are otherwise non-clickable in TimelineRow, so dropping the sessionId prop here removes the only control that can open the live SessionModal during that gap (apps/staged/src/lib/features/timeline/TimelineRow.svelte:73-95). In practice, right after starting a commit/note/review session, users can no longer inspect or stop it until getBranchTimeline() eventually returns the persisted item.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
1 participant
Summary
sessionIdprop from pending timeline items inBranchTimeline.svelteso the session button doesn't appear prematurely on items that haven't started yet.Test plan
🤖 Generated with Claude Code