-
Notifications
You must be signed in to change notification settings - Fork 7
feat(settings): add repo context search #583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+97
−1
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
47ee93d
feat(settings): add repo list search
matt2e a0eb63d
fix(settings): match repo search across repo and subpath
matt2e f8f43d2
fix(settings): shorten repo search placeholder
matt2e f93e543
fix(settings): shorten repo settings search placeholder
matt2e 41f8b75
fix(settings): split repo subpath search terms
matt2e File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
apps/staged/src/lib/features/settings/repoContextSearch.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| import { describe, expect, it } from 'vitest'; | ||
| import { matchesRepoContextSearch } from './repoContextSearch'; | ||
| import type { ActionContext } from '../../api/commands'; | ||
|
|
||
| const context: ActionContext = { | ||
| id: 'ctx-1', | ||
| githubRepo: 'block/builderbot', | ||
| subpath: 'apps/staged', | ||
| hasDetectedActions: false, | ||
| detectingActions: false, | ||
| createdAt: 0, | ||
| updatedAt: 0, | ||
| }; | ||
|
|
||
| describe('matchesRepoContextSearch', () => { | ||
| it('matches tokens across repo and subpath fields', () => { | ||
| expect(matchesRepoContextSearch(context, 'staged block')).toBe(true); | ||
| }); | ||
|
|
||
| it('matches tokens regardless of order', () => { | ||
| expect(matchesRepoContextSearch(context, 'builderbot apps')).toBe(true); | ||
| }); | ||
|
|
||
| it('matches case-insensitively', () => { | ||
| expect(matchesRepoContextSearch(context, 'BLOCK STAGED')).toBe(true); | ||
| }); | ||
|
|
||
| it('handles missing subpaths', () => { | ||
| expect( | ||
| matchesRepoContextSearch( | ||
| { | ||
| ...context, | ||
| subpath: null, | ||
| }, | ||
| 'builderbot' | ||
| ) | ||
| ).toBe(true); | ||
| }); | ||
|
|
||
| it('requires every token to match some repo term', () => { | ||
| expect(matchesRepoContextSearch(context, 'staged unknown')).toBe(false); | ||
| }); | ||
| }); |
19 changes: 19 additions & 0 deletions
19
apps/staged/src/lib/features/settings/repoContextSearch.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import type { ActionContext } from '../../api/commands'; | ||
|
|
||
| function searchTerms(context: ActionContext): string[] { | ||
| const githubRepo = context.githubRepo.toLowerCase(); | ||
| const [org = '', repoName = ''] = githubRepo.split('/'); | ||
| const subpath = context.subpath?.toLowerCase() ?? ''; | ||
| const subpathParts = subpath.split('/').filter(Boolean); | ||
|
|
||
| return [githubRepo, org, repoName, subpath, ...subpathParts].filter(Boolean); | ||
| } | ||
|
|
||
| export function matchesRepoContextSearch(context: ActionContext, query: string): boolean { | ||
| const tokens = query.toLowerCase().trim().split(/\s+/).filter(Boolean); | ||
|
|
||
| if (tokens.length === 0) return true; | ||
|
|
||
| const terms = searchTerms(context); | ||
| return tokens.every((token) => terms.some((term) => term.includes(token))); | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The matcher never indexes the combined
githubRepo/subpathlabel, so a query likeblock/builderbot/apps/staged(which matches how the repo is displayed in the sidebar/title) returns no results even for an exact visible context. This makes exact copy/paste searches fail unless users manually insert spaces between segments, which is a functional mismatch for the new search UX.Useful? React with 👍 / 👎.