-
Notifications
You must be signed in to change notification settings - Fork 10
feat(staged): centralize PR polling with tiered intervals and PR recovery #650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b2ef51b
fix(staged): replace per-component PR polling with centralized service
matt2e c550291
feat(staged): add info-level debug logging to PR polling service and …
matt2e b473208
fix(staged): emit session running event atomically from backend commands
matt2e 2fce3bc
feat(staged): recover missing PR numbers on component mount
matt2e 788f115
chore(staged): remove [PrPolling] debug logs from polling service and…
matt2e 896d83e
feat(staged): make PR polling app-wide with tiered intervals per project
matt2e c7abde0
fix(staged): address PR polling review comments — concurrency and cle…
matt2e 2cb1f06
fix(staged): address review — use Set for pending refreshes and retry…
matt2e 92ead48
fix(staged): simplify pending refresh drain loop in PR polling service
matt2e File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This emits a
runningsession event beforestart_session(...)can fail, so if startup fails (for example provider/driver initialization errors), the command returns an error but the frontend has already registered the session as running via the global listener and may never receive a terminal event to clean it up. That leaves project/session UI stuck in a running state for PR creation (and the same ordering is repeated in the push path below).Useful? React with 👍 / 👎.