Skip to content

fix: prevent duplicate action detection on re-navigation #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matt2e merged 1 commit into from
Apr 24, 2026
+31 −2
Merged

fix: prevent duplicate action detection on re-navigation #653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions apps/staged/src-tauri/src/actions/commands.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,9 @@ pub async fn detect_repo_actions(
let context = store
.get_or_create_action_context(&github_repo, subpath.as_deref())
.map_err(|e| format!("Failed to get action context: {e}"))?;
if context.detecting_actions {
return Err("Detection is already in progress for this repository".into());
Comment on lines +119 to +120
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Permit retries when persisted detection flag is stale

This new guard can permanently block action detection after an interrupted run. detecting_actions is stored in SQLite, so if the app is closed/crashes after set_action_context_detecting(..., true) but before mark_action_context_detected, the flag remains true across restart; every later detect_repo_actions call will hit this early return even though no detection is actually running. This creates a stuck repo context that users cannot recover from in settings.

Useful? React with 👍 / 👎.

}
store
.set_action_context_detecting(&context.id, true)
.map_err(|e| format!("Failed to set detection status: {e}"))?;
Expand Down
30 changes: 28 additions & 2 deletions apps/staged/src/lib/features/settings/ActionsSettingsPanel.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<script lang="ts">
import { onMount, untrack } from 'svelte';
import { onMount, onDestroy, untrack } from 'svelte';
import {
FolderGit2,
Play,
Expand All @@ -22,7 +22,11 @@
import ConfirmDialog from '../../shared/ConfirmDialog.svelte';
import type { ActionContext, ProjectAction } from '../../api/commands';
import * as commands from '../../api/commands';
import { detectRepoActions, type ActionType } from '../actions/actions';
import {
detectRepoActions,
listenToRepoActionsDetection,
type ActionType,
} from '../actions/actions';
import { repoBadgeStore } from '../../stores/repoBadges.svelte';
import { matchesRepoSearch } from './repoContextSearch';

Expand Down Expand Up @@ -66,12 +70,30 @@
let badgeEditHue = $state(0);
let badgeError = $state('');

let unlistenDetection: (() => void) | undefined;

onMount(async () => {
listenToRepoActionsDetection((event) => {
const ctx = selectedContext;
if (!ctx) return;
if (event.githubRepo !== ctx.githubRepo || event.subpath !== (ctx.subpath ?? null)) return;
detecting = event.detecting;
if (!event.detecting) {
loadActions();
}
}).then((unlisten) => {
unlistenDetection = unlisten;
});

await repoBadgeStore.loadAll();
await loadContexts();
await ensureBadgesForContexts(contexts);
});

onDestroy(() => {
unlistenDetection?.();
});

async function ensureBadgesForContexts(ctxs: ActionContext[]) {
if (ctxs.length === 0) return;
await repoBadgeStore.ensureForRepos(
Expand Down Expand Up @@ -256,6 +278,10 @@
loadActions();
});

$effect(() => {
detecting = selectedContext?.detectingActions ?? false;
});

async function detectActions() {
if (!selectedContext) return;

Expand Down