Fix included-build outputs missing from save bundles#11
Merged
joshfriend merged 1 commit intomainfrom Apr 14, 2026
Merged
Conversation
joshfriend
force-pushed
the
fix-included-build-save
branch
2 times, most recently
from
952e124 to
309d1ad
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0c101930ee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
joshfriend
force-pushed
the
fix-included-build-save
branch
2 times, most recently
from
3ff2b4e to
53de696
Compare
Kong's type:"path" resolved --included-build values to absolute paths, causing ConventionBuildDirs to construct invalid doubled paths that silently matched nothing. Drop type:"path", validate paths upfront, and bake an included build into the default integration fixture.
joshfriend
force-pushed
the
fix-included-build-save
branch
from
53de696 to
21d904c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kong's
type:"path"resolved--included-buildvalues to absolute paths, causingConventionBuildDirsto construct invalid doubled paths that silently matched nothing. Drop type:"path", validate paths upfront, and bake an included build into the default integration fixture.