fix desktop canvas header blur in split channel management#1558
Merged
Conversation
In split layout, ChannelManagementSheet's DialogPrimitive.Content applied backdrop-blur-xl in dark mode. backdrop-filter creates a stacking context, which trapped the panel's z-40 header beneath ChannelPane's shared z-30 header blur strip, leaving the Canvas/channel header row blurred over and its back button invisible but still hit-testable. Drop the translucent blur surface from the split branch: the pane already renders on the opaque bg-background from PANEL_BASE_CLASS, so the blur was visually inert there. Overlay and standalone modes keep their blur. Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
wesbillman
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category: fix
User Impact: The Canvas panel header stays readable and clickable in dark-mode split layouts.
Problem: Opening Canvas from channel management in dark mode could blur out the header controls, leaving the back and close buttons present but visually hidden behind the shared channel header strip.
Solution: Remove the inert translucent blur surface from the docked channel-management dialog wrapper so it no longer creates a stacking context above the Canvas header. Overlay and standalone panel chrome keep their existing blur behavior.
File changes
desktop/src/features/channels/ui/ChannelManagementSheet.tsx
Drops the dark-mode
backdrop-blur-xlsurface from the split-layoutDialogPrimitive.Contentand documents why the docked pane should stay on the opaque base background. This preventsbackdrop-filterfrom trapping the Canvas header beneath the shared channel header blur strip while leaving overlay/standalone mode unchanged.Reproduction Steps
Canvastitle, and close action remain crisp and visible in the header.Screenshots/Demos
Marge reproduced the regression on latest
origin/mainand verified the fix on this branch.Before (
origin/main) — title, back, and close blurred out:After (
d3fe2dad) — back,Canvastitle, and close are crisp:Full pane before / after:
Validation
biome check .✅pnpm check✅tsc --noEmit✅channel-shared-header-backdrop+channel-controls— 9 passed ✅