feat: Configure dynamic loglevel update#157
Merged
Conversation
nssherpa
changed the title
alecthomas
reviewed
Feb 24, 2026
internal/logging/logging.go
Outdated
| func Configure(ctx context.Context, config Config) (*slog.Logger, context.Context) { | ||
| // Configure sets up logging with the given config and returns a logger, a LevelVar | ||
| // that can be used to dynamically change the log level at runtime, and the updated context. | ||
| func Configure(ctx context.Context, config Config) (*slog.Logger, *slog.LevelVar, context.Context) { |
Collaborator
There was a problem hiding this comment.
Given that there's only one LevelVar for the entire process, I think it's safe to just make this a global and have corresponding global SetLevel()/GetLevel() functions. That will vastly simplify this PR.
nssherpa
changed the title
alecthomas
approved these changes
Feb 24, 2026
Collaborator
|
I'd also maybe consider using JSON payload for getting/setting the level for consistency with the rest of the system, but I'm not that fussed for an admin endpoint. |
Collaborator
Author
|
Skipping the json payload for the endpoint for now. But addressed the other comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing
Tested with switching from info to debug to info..