fix: restore correct remote URL in git snapshots#159
Merged
Conversation
01e87f8 to
d475f95
Compare
dd65913 to
a0ee78f
Compare
When generating a snapshot, `git clone <local-mirror-path>` sets `remote.origin.url` to the local mirror path. After cloning, reset the origin URL to the actual upstream so clients can run `git pull` after extracting the snapshot. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
a0ee78f to
e0210d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When generating a snapshot,
git clone <local-mirror-path>causes Git to write the local mirror path asremote.origin.urlin the snapshot's.git/config. After clients extract the snapshot and rungit pull, Git tries to reach the local path (e.g./app/state/git-mirrors/github.com/squareup/java) which doesn't exist on their machine.Fix: after the local clone, run
git remote set-url origin <upstream>to restore the correct upstream URL before archiving the snapshot.Testing
git pull, checkgit config, etc. The url is now correct.previously it would be something like this