fix: fold LFS snapshot scheduling into scheduleSnapshotJobs#264
Merged
joshfriend merged 1 commit intomainfrom Apr 16, 2026
Merged
fix: fold LFS snapshot scheduling into scheduleSnapshotJobs#264joshfriend merged 1 commit intomainfrom
joshfriend merged 1 commit intomainfrom
Conversation
scheduleLFSSnapshotJobs was missing from the writeSnapshotSpool and scheduleDeferredMirrorRestore code paths, so repos first initialized through cold-start or on-demand spool never had LFS snapshots generated. Fold the LFS periodic job into scheduleSnapshotJobs so every caller gets it automatically.
joshfriend
force-pushed
the
fix-lfs-snapshot-schedule
branch
from
a2a8dec to
c513262
Compare
worstell
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scheduleLFSSnapshotJobs was a separate function that needed to be called alongside scheduleSnapshotJobs at every call site. Two paths added before LFS support (writeSnapshotSpool and scheduleDeferredMirrorRestore) were missing the call, so repos first initialized through cold-start or on-demand spool never had their LFS periodic job registered.
This folds the LFS periodic job into scheduleSnapshotJobs itself so there's only one function to call and every code path gets LFS scheduling automatically.
Discovered because ios-register never had an LFS snapshot generated. It was always initialized through the cold-start path. Other repos like cash-android worked by luck: their mirrors survived pod restarts on the persistent volume, so warmExistingRepos (which had the correct call) kept their LFS jobs scheduled.