feat: add CRC64-NVME upload checksums to S3 cache#282
Merged
joshfriend merged 1 commit intomainfrom Apr 30, 2026
Merged
Conversation
joshfriend
force-pushed
the
jfriend/s3-crc64-checksum
branch
2 times, most recently
from
9388361 to
09f6b4d
Compare
joshfriend
changed the title
joshfriend
changed the title
joshfriend
force-pushed
the
jfriend/s3-crc64-checksum
branch
3 times, most recently
from
803fc97 to
e9e3f38
Compare
joshfriend
requested review from
jrobotham-square
and removed request for
a team
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e9e3f38490
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
joshfriend
force-pushed
the
jfriend/s3-crc64-checksum
branch
from
e9e3f38 to
9d08b8e
Compare
alecthomas
approved these changes
Apr 30, 2026
Enable CRC64-NVME checksums on S3 uploads for server-side integrity validation. Also refactor S3 test helpers and fix soak test TTL.
joshfriend
force-pushed
the
jfriend/s3-crc64-checksum
branch
from
9d08b8e to
fdcfc26
Compare
joshfriend
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable CRC64-NVME checksums on S3 uploads for server-side integrity validation. Also refactor S3 test helpers and fix soak test TTL.