feat(git): forward snapshot ETag and support HEAD requests#337
Merged
Conversation
The common bundle-serving path (serveSnapshotWithBundle) dropped the cached ETag and Content-Length, so clients could not revalidate snapshots. Forward both validators via a shared applySnapshotCacheHeaders helper. Add HEAD support backed by the cache's Stat() so probes never read or generate the body, or warm up a mirror. HEAD reports the ETag, Content-Length and snapshot commit, returns 404 when uncached, and honours If-None-Match/If-Match via the now-exported CheckConditionals helper. Closes #334
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b6bb63b581
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This was referenced Jun 22, 2026
alecthomas
added a commit
that referenced
this pull request
Jun 22, 2026
serveSnapshotWithBundle advertises the snapshot ETag but, for cache backends that return non-*os.File readers (S3, memory, remote tier), fell through to io.Copy and never evaluated If-None-Match/If-Match. A revalidating client therefore received a full 200 body instead of 304. Evaluate strategy.CheckConditionals after applying the cached headers and before streaming, short-circuiting to 304/412 for all reader types. File-backed readers already got this via http.ServeContent. Addresses Codex review feedback on #337.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The common bundle-serving path (serveSnapshotWithBundle) dropped the cached ETag and Content-Length, so clients could not revalidate snapshots. Forward both validators via a shared applySnapshotCacheHeaders helper.
Add HEAD support backed by the cache's Stat() so probes never read or generate the body, or warm up a mirror. HEAD reports the ETag, Content-Length and snapshot commit, returns 404 when uncached, and honours If-None-Match/If-Match via the now-exported CheckConditionals helper.
Closes #334