Regenerate models from updated Vantage API spec#3
Merged
orest-tokovenko-block merged 2 commits intomainfrom Feb 12, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerated models from the latest Vantage OpenAPI spec after Vantage fixed several type issues we reported
Spec fixes (BudgetAlert)
These were the fields we specifically requested fixes for:
duration_in_days- wasstring, nowint | None(not required)user_token- now nullablerecipient_channels- wasstring, nowSequence[str] | NoneOther spec fixes
Costs.total_cost- wasMapping[str, Any], now typed asCostPartialCosts.total_usage- wasMapping[str, Any], nowSequence[UsagePartial]DataExport.attributes- wasstr, nowMapping[str, Any]DataExportManifest.files- wasstr, nowSequence[str]DataExportManifest.completed_at/valid_until- now nullableResource.metadata- wasstr, nowMapping[str, Any] | NoneResourceCost.amount- wasstr, nowfloatRecommendation.resources_affected_count- wasstr, nowintCostReportSettings- all boolean fields now nullableBillingRule.apply_to_all- now nullableBusinessMetric.import_type- now nullableAttachedCostReportForBusinessMetric.cost_report_token- now nullableMe.default_workspace_token- now nullableForecastedCostProvider- addedallenum valueNew models
CostPartial,UsagePartial,CostReportUrl,SendInvoiceRemoved redundant overrides from
common.pyThese overrides existed to fix types that the spec now defines correctly:
BudgetAlert/BudgetAlertsMeBusinessMetric/BusinessMetricsCostReportSettingsResource/ResourcesNot fixed upstream
Inline
settingsobjects (CostReport.settings,DashboardWidget.settings) are still unnamed in the spec. Vantage confirmed this is not something they can patch easily.