Hide brainstorm plans from index for non-authors#89
Merged
HamptonMakes merged 1 commit intomainfrom Apr 9, 2026
Merged
Conversation
Brainstorm plans are now filtered from the web PlansController#index unless they belong to the current user, matching the existing API behavior. Direct-link access (show page) remains open to all users. Amp-Thread-ID: https://ampcode.com/threads/T-019d7419-03da-732b-b985-ebd3d24e0997 Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Filters brainstorm plans from the web
PlansController#indexunless they belong to the current user, matching the existing API behavior.Why
Brainstorm plans are private drafts. The API index already hides them from non-authors, but the web index was showing all plans regardless of status. This closes that gap.
How
Added
.where.not(status: "brainstorm").or(Plan.where(created_by_user: current_user))to the web index query — the same pattern the API controller uses.Testing