fix: bedrock provider to only include non user annotations and convert non supported docs to text #1899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zakiali
force-pushed
the
zaki/bedrock-provider-fix
branch
from
72ba85e to
9c38348
Compare
kalvinnchau
approved these changes
Mar 28, 2025
Comment on lines
66
to
69
| .filter(|c| { | ||
| if let Some(audience) = c.audience() { | ||
| !audience.contains(&Role::User) | ||
| } else { | ||
| true // Include if no audience annotation | ||
| } | ||
| }) |
Contributor
There was a problem hiding this comment.
you could also write this as:
.filter(|c| c.audience().map_or(true, |audience| !audience.contains(&Role::User)))map_or would default to true in the None case, and run the filter otherwise
zakiali
force-pushed
the
zaki/bedrock-provider-fix
branch
from
9c38348 to
0e62b85
Compare
…t non supported docs to text
zakiali
force-pushed
the
zaki/bedrock-provider-fix
branch
from
0e62b85 to
1b4d1f3
Compare
ahau-square
pushed a commit
that referenced
this pull request
May 2, 2025
…t non supported docs to text (#1899)
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
…t non supported docs to text (block#1899)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr resolves this issue #1500 and removes tool result user annotations from the context (which may have been bloating the context)