Conversation
lifeizhou-ap
requested review from
The-Best-Codes and
michaelneale
and removed request for
The-Best-Codes and
Copilot
michaelneale
left a comment
michaelneale
left a comment
There was a problem hiding this comment.
approving to unblock @lifeizhou-ap - but not sure if this is intended to not include .deb and .rpm?
|
For context (for others reviewing this PR), here is the failing release workflow: I kicked off the workflow again earlier on, and it is even worse. So this PR should fix it |
Thanks @michaelneale. We published our assets in .deb and .rpm separately, and their artifacts are uploaded via the previous steps "Upload .deb package" and "Upload .rpm package" in That's why I think the |
|
Ohhh gotcha. Let me take a look at that workflow again. |
* main: fix: fixed the broken release (#6887) feat: Streamable HTTP transport for ACP + goose-acp usage (#6741) Add Laminar for Observability (#6514) Missed a couple of places that hard code J for the newline key (#6853) fix(ui): preserve working directory when creating new chat (#6789) blog: add 5 tips for building MCP Apps that work (#6855) docs: session isolation (#6846) upgrade react and electron to latest (#6845) Fix: Small update UI settings prompt injection (#6830) Remove autogenerated .gooseignore files that don't belong in repo (#6824) Fix case-insensitive matching for builtin extension names (#6825) docs: cli newline keybinding (#6823) Update version to 1.22.0 (#6821) Refactor: move persisting extension to session outside of route (#6685) acp: load configured extensions and refactor tests (#6803)
Signed-off-by: Harrison <hcstebbins@gmail.com>
3 participants
Summary
Why
User reports the stable download url returns "not found" error
Root cause
Since V1.22.0 release, we published the flatpak artifacts from downloading
**/*.flatpakIn the
bundle-desktop-linuxworkflows, it has two stepsGoose-linux-x64-flatpakandGoose-linux-x64, both of them include the same flatpack artifact, but with different paths.Then in the
release.ymlworkflow, when it downloads**/*.flatpak, it download 2 files with same name. This caused the warning message "Warning: Failed to upload artifact io.atom.electron.goose-app_stable_x86_64.flatpak. Validation Failed: {"resource":"ReleaseAsset","code":"already_exists","field":"name"} - https://docs.github.com/rest." inrelease versionandrelease stable, andrelease versionThey works ok even with the warning message
However, the V1.22.1
release stablefailed with "Error: Error 404: Not Found - https://docs.github.com/rest/releases/assets#delete-a-release-asset" because it had problem to delete the duplicate assets in the same tag.What
Goose-linux-x64step to avoid release step downloading the same artifact. It seems this step is not referred by anywhereType of Change