fix(google): handle thoughtSignature differently for Gemini 2.5 vs 3#6890
Merged
alexhancock merged 1 commit intoblock:mainfrom Feb 2, 2026
Merged
fix(google): handle thoughtSignature differently for Gemini 2.5 vs 3#6890alexhancock merged 1 commit intoblock:mainfrom
alexhancock merged 1 commit intoblock:mainfrom
Conversation
…mini 3 Fixes a regression introduced in e4938c6 where Gemini 2.5 Pro's first streaming chunk got hidden, as it changed streaming to treat all signed text as Thinking content to fix Gemini 3's intermittent 400 errors. However, Gemini 2.5 behaves differently with thoughtSignature: - Gemini 3: Uses thoughtSignature for actual thinking/reasoning content. Requires the signature to be preserved and sent back to avoid intermittent 400 errors ("content block missing a thought_signature"). - Gemini 2.5: Includes thoughtSignature on the first chunk as metadata, not actual thinking. This is regular text. Signed-off-by: rabi <ramishra@redhat.com>
alexhancock
approved these changes
Feb 2, 2026
stebbins
pushed a commit
to stebbins/goose
that referenced
this pull request
Feb 4, 2026
…lock#6890) Signed-off-by: rabi <ramishra@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a regression introduced in e4938c6 where Gemini 2.5 Pro's first streaming chunk got hidden, as it changed streaming to treat all signed text as Thinking content to fix Gemini 3's intermittent 400 errors. However, Gemini 2.5 behaves differently with thoughtSignature:
Gemini 3: Uses thoughtSignature for actual thinking/reasoning content. Requires the signature to be preserved and sent back to avoid intermittent 400 errors ("content block missing a thought_signature").
Gemini 2.5: Includes thoughtSignature on the first chunk as metadata, not actual thinking. This is regular text.
Type of Change
Testing
Tested locally with 3.0/2.5 models.