fix tool confirmations not showing up mid chat #6935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelneale
approved these changes
Feb 4, 2026
stebbins
pushed a commit
to stebbins/goose
that referenced
this pull request
Feb 4, 2026
Signed-off-by: Harrison <hcstebbins@gmail.com>
kuccello
pushed a commit
to kuccello/goose
that referenced
this pull request
Feb 7, 2026
Tyler-Hardin
pushed a commit
to Tyler-Hardin/goose
that referenced
this pull request
Feb 11, 2026
Tyler-Hardin
pushed a commit
to Tyler-Hardin/goose
that referenced
this pull request
Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The frontend was checking for the wrong message type when detecting tool confirmation requests.
BEFORE (incorrect):
content.type === 'toolConfirmationRequest'
AFTER (correct):
content.type === 'actionRequired' && content.data.actionType === 'toolConfirmation'
The backend sends tool confirmations as
actionRequiredmessages withactionType: 'toolConfirmation',not as a separate
toolConfirmationRequesttype. This mismatch meant the frontend never recognizedconfirmation requests, so the chat state never transitioned to
WaitingForUserInputand the dialognever appeared.
Also noticed we can't set tool permissions without a session so added some fallback text (will follow up with setting without a session in defaults like extensions)
fixes #6925