fix(google): add MessageContent::Image support for user messages #6986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #6983 The Google/Gemini provider was silently dropping images attached to user messages because MessageContent::Image fell through to the catch-all case in format_messages(). This adds handling for MessageContent::Image using the same inline_data format already used for images in tool responses.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the Google/Gemini provider was silently dropping images attached to user messages in the CLI. The fix adds proper handling for MessageContent::Image in the format_messages() function using the same inline_data format already used for images in tool responses.
Changes:
- Added
MessageContent::Imagehandling informat_messages()to format images with inline_data structure expected by Google API - Added test case to verify image messages are properly formatted with mime_type and data fields
jh-block
approved these changes
Feb 5, 2026
kuccello
pushed a commit
to kuccello/goose
that referenced
this pull request
Feb 7, 2026
Tyler-Hardin
pushed a commit
to Tyler-Hardin/goose
that referenced
this pull request
Feb 11, 2026
Tyler-Hardin
pushed a commit
to Tyler-Hardin/goose
that referenced
this pull request
Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6983
The Google/Gemini provider was silently dropping images attached to user messages in the CLI because the Image variant fell through to the catch-all case in format_messages().
Changes
Technical Details
The fix uses the same inline_data structure already used for images in tool responses, ensuring consistency with Google Gemini API specification.
Testing