refactor: move disable_session_naming into AgentConfig#7062
Merged
codefromthecrypt merged 1 commit intomainfrom Feb 7, 2026
Merged
refactor: move disable_session_naming into AgentConfig#7062codefromthecrypt merged 1 commit intomainfrom
codefromthecrypt merged 1 commit intomainfrom
Conversation
codefromthecrypt
force-pushed
the
adrian/session-disable
branch
from
965c814 to
395d68f
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the session-naming disable switch so it can be passed via AgentConfig/AcpServerConfig (instead of being read directly at the point of use), and updates ACP/scenario tests + OpenAI scenario recordings accordingly.
Changes:
- Add
disable_session_naming: booltoAgentConfigand thread it into the agent’s session-naming logic. - Promote the same flag into
AcpServerConfig, update ACP fixtures/tests to disable naming, and remove the session-rename interception/fixture. - Update scenario test runner config and re-record OpenAI scenario fixtures to remove the extra session-naming interaction.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/goose/src/agents/agent.rs | Adds disable_session_naming to AgentConfig and gates async session naming on the config value. |
| crates/goose/src/execution/manager.rs | Passes the global disable flag into AgentConfig::new when creating agents via AgentManager. |
| crates/goose/tests/agent.rs | Updates unit tests to the new AgentConfig::new signature. |
| crates/goose-cli/src/scenario_tests/scenario_runner.rs | Sets disable_session_naming = true for scenario tests to keep recordings stable. |
| crates/goose-cli/src/scenario_tests/recordings/openai/what_is_your_name.json | Re-recorded OpenAI scenario without the session-naming interaction. |
| crates/goose-cli/src/scenario_tests/recordings/openai/weather_tool.json | Re-recorded OpenAI scenario without the session-naming interaction. |
| crates/goose-cli/src/scenario_tests/recordings/openai/image_analysis.json | Re-recorded OpenAI scenario without the session-naming interaction. |
| crates/goose-acp/src/server.rs | Adds disable_session_naming to AcpServerConfig and passes it into AgentConfig. |
| crates/goose-acp/src/server_factory.rs | Constructs AcpServerConfig for ACP server creation (currently hard-codes the new flag). |
| crates/goose-acp/tests/fixtures/mod.rs | Removes session-rename interception and sets disable_session_naming = true in ACP test config. |
| crates/goose-acp/tests/test_data/openai_session_description.json | Removes no-longer-needed fixture used for session rename interception. |
| clippy-baselines/too_many_lines.txt | Updates clippy baseline entries impacted by unrelated code movement/line count changes. |
DOsinga
approved these changes
Feb 7, 2026
baxen
approved these changes
Feb 7, 2026
codefromthecrypt
force-pushed
the
adrian/session-disable
branch
from
395d68f to
9c83f1e
Compare
Replace the Config::global() read in reply_internal with an AgentConfig parameter, following the goose_mode pattern. ACP tests and scenario tests set the flag to true, removing canned fixtures and session naming from recorded interactions. Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
force-pushed
the
adrian/session-disable
branch
from
9c83f1e to
98a8658
Compare
1 task
zanesq
added a commit
that referenced
this pull request
Feb 7, 2026
* 'main' of github.com:block/goose: refactor: move disable_session_naming into AgentConfig (#7062) Add global config switch to disable automatic session naming (#7052) docs: add blog post - 8 Things You Didn't Know About Code Mode (#7059) fix: ensure animated elements are visible when prefers-reduced-motion is enabled (#7047) Show recommended model on failture (#7040) feat(ui): add session content search via API (#7050) docs: fix img url (#7053) Desktop UI for deleting custom providers (#7042) Add blog post: How I Used RPI to Build an OpenClaw Alternative (#7051)
kuccello
pushed a commit
to kuccello/goose
that referenced
this pull request
Feb 7, 2026
Signed-off-by: Adrian Cole <adrian@tetrate.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move
disable_session_namingfrom a global config read into an injectableAgentConfigparameter, following thegoose_modepattern.disable_session_namingtoAgentConfigandAcpServerConfigtrue, removing theopenai_session_description.jsonfixture and session rename intercepttrue, re-recorded OpenAI scenarios without the session naming interactionType of Change
AI Assistance
Testing
All existing tests pass with
cargo testandscripts/clippy-lint.sh.To re-record OpenAI scenarios:
Related Issues
Builds on #7052