Skip to content

fix(ui): preserve server config values on partial provider config save#7248

Merged
DOsinga merged 1 commit intoblock:mainfrom
clayarnoldg2m:fix/7245-provider-config-partial-save
Feb 17, 2026
Merged

fix(ui): preserve server config values on partial provider config save#7248
DOsinga merged 1 commit intoblock:mainfrom
clayarnoldg2m:fix/7245-provider-config-partial-save

Conversation

@clayarnoldg2m
Copy link
Contributor

@clayarnoldg2m clayarnoldg2m commented Feb 16, 2026

Summary

  • Fixes OpenAI API Host falls back to default when saving other fields #7245 — OpenAI API Host (and other non-secret config fields) silently revert to default when saving a partial provider configuration
  • The submit filter in ProviderConfiguationModal.tsx now includes fields with existing non-masked server values (serverValue as plain string), not just fields where the user typed a new value
  • Masked/secret values are correctly excluded from the fallback (they remain on the server unchanged)

Test plan

  • Configure a provider with both API Host and API Key set
  • Edit only the API Key (leave Host untouched) and save
  • Verify the Host value persists (previously it silently reverted to default)
  • Verify secret fields (masked values) still work correctly when unchanged
  • TypeScript type check passes: npx tsc --noEmit

🤖 Generated with Claude Code

@clayarnoldg2m @claude
fix(ui): preserve server config values on partial provider config save
5632b88 
The submit filter in ProviderConfiguationModal only included fields where
the user had typed a new value (entry.value), causing untouched fields like
API Host to be silently dropped. Now the filter also includes fields with
existing non-masked server values (entry.serverValue), preventing config
reversion when only some fields are edited.

Fixes block#7245

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: clayarnoldg2m <carnold@g2m.ai>
@DOsinga DOsinga requested a review from Copilot February 17, 2026 13:57
Copilot AI reviewed Feb 17, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a critical bug where non-secret provider configuration fields (like OpenAI API Host) would silently revert to their default values when saving changes to other fields. The root cause was that the submit logic only included fields where the user entered a new value, ignoring fields with existing server values that weren't modified.

Changes:

  • Modified the submit filter to include fields with existing non-masked server values in addition to fields with new user input
  • Updated the value mapping to use the nullish coalescing operator to correctly fall back to server values when user input is absent
  • Secret/masked values remain correctly excluded from submission

@DOsinga
Copy link
Collaborator

DOsinga commented Feb 17, 2026

thanks, same as #7246

@DOsinga DOsinga added this pull request to the merge queue Feb 17, 2026
Merged via the queue into block:main with commit 8533e8d Feb 17, 2026
25 checks passed
zanesq added a commit that referenced this pull request Feb 17, 2026
@zanesq
Merge branch 'main' of github.com:block/goose into zane/validate-bund…
9ccc8eb 
…led-extensions-cmd

* 'main' of github.com:block/goose: (24 commits)
  Set up direnv and update flake inputs (#6526)
  fix: restore subagent tool call notifications after summon refactor (#7243)
  fix(ui): preserve server config values on partial provider config save (#7248)
  fix(claude-code): allow goose to run inside a Claude Code session (#7232)
  fix(openai): route gpt-5 codex via responses and map base paths (#7254)
  feat: add GoosePlatform to AgentConfig and MCP initialization (#6931)
  Fix copied over (#7270)
  feat(gemini-cli): add streaming support via stream-json events (#7244)
  fix: filter models without tool support from recommended list (#7198)
  fix(google): handle more thoughtSignature vagaries during streaming (#7204)
  docs: playwright CLI skill tutorial (#7261)
  install node in goose dir (#7220)
  fix: relax test_basic_response assertion for providers returning reasoning_content (#7249)
  fix: handle reasoning_content for Kimi/thinking models (#7252)
  feat: sandboxing for macos (#7197)
  fix(otel): use monotonic_counter prefix and support temporality env var (#7234)
  Streaming markdown (#7233)
  Improve compaction messages to enable better post-compaction agent behavior (#7259)
  fix: avoid shell-escaping special characters except quotes (#7242)
  fix: use dynamic port for Tetrate auth callback server (#7228)
  ...
katzdave added a commit to YusukeShimizu/goose that referenced this pull request Feb 17, 2026
@katzdave
Merge remote-tracking branch 'origin/main' into responses-gpt-5.2-x
f9401ba 
* origin/main: (263 commits)
  working_dir usage more clear in add_extension (block#6958)
  Use Canonical Models to set context window sizes (block#6723)
  Set up direnv and update flake inputs (block#6526)
  fix: restore subagent tool call notifications after summon refactor (block#7243)
  fix(ui): preserve server config values on partial provider config save (block#7248)
  fix(claude-code): allow goose to run inside a Claude Code session (block#7232)
  fix(openai): route gpt-5 codex via responses and map base paths (block#7254)
  feat: add GoosePlatform to AgentConfig and MCP initialization (block#6931)
  Fix copied over (block#7270)
  feat(gemini-cli): add streaming support via stream-json events (block#7244)
  fix: filter models without tool support from recommended list (block#7198)
  fix(google): handle more thoughtSignature vagaries during streaming (block#7204)
  docs: playwright CLI skill tutorial (block#7261)
  install node in goose dir (block#7220)
  fix: relax test_basic_response assertion for providers returning reasoning_content (block#7249)
  fix: handle reasoning_content for Kimi/thinking models (block#7252)
  feat: sandboxing for macos (block#7197)
  fix(otel): use monotonic_counter prefix and support temporality env var (block#7234)
  Streaming markdown (block#7233)
  Improve compaction messages to enable better post-compaction agent behavior (block#7259)
  ...

# Conflicts:
#	crates/goose/src/providers/openai.rs
zanesq added a commit that referenced this pull request Feb 17, 2026
@zanesq
Merge branch 'main' of github.com:block/goose into zane/recipe-extens…
47c601c 
…ions-fallback

* 'main' of github.com:block/goose: (43 commits)
  Added cmd to validate bundled extensions json (#7217)
  working_dir usage more clear in add_extension (#6958)
  Use Canonical Models to set context window sizes (#6723)
  Set up direnv and update flake inputs (#6526)
  fix: restore subagent tool call notifications after summon refactor (#7243)
  fix(ui): preserve server config values on partial provider config save (#7248)
  fix(claude-code): allow goose to run inside a Claude Code session (#7232)
  fix(openai): route gpt-5 codex via responses and map base paths (#7254)
  feat: add GoosePlatform to AgentConfig and MCP initialization (#6931)
  Fix copied over (#7270)
  feat(gemini-cli): add streaming support via stream-json events (#7244)
  fix: filter models without tool support from recommended list (#7198)
  fix(google): handle more thoughtSignature vagaries during streaming (#7204)
  docs: playwright CLI skill tutorial (#7261)
  install node in goose dir (#7220)
  fix: relax test_basic_response assertion for providers returning reasoning_content (#7249)
  fix: handle reasoning_content for Kimi/thinking models (#7252)
  feat: sandboxing for macos (#7197)
  fix(otel): use monotonic_counter prefix and support temporality env var (#7234)
  Streaming markdown (#7233)
  ...

# Conflicts:
#	crates/goose/src/config/extensions.rs
jh-block added a commit that referenced this pull request Feb 18, 2026
@jh-block
Merge remote-tracking branch 'origin/main' into local-models-candle
6687f66 
* origin/main: (49 commits)
  chore: show important keys for provider configuration (#7265)
  fix: subrecipe relative path with summon (#7295)
  fix extension selector not displaying the correct enabled extensions (#7290)
  Use the working dir from the session (#7285)
  Fix: Minor logging uplift for debugging of prompt injection mitigation (#7195)
  feat(otel): make otel logging level configurable (#7271)
  docs: add documentation for Top Of Mind extension (#7283)
  Document gemini 3 thinking levels (#7282)
  docs: stream subagent tool calls (#7280)
  Docs: delete custom provider in desktop (#7279)
  Everything is streaming (#7247)
  openai: responses models and hardens event streaming handling (#6831)
  docs: disable ai session naming (#7194)
  Added cmd to validate bundled extensions json (#7217)
  working_dir usage more clear in add_extension (#6958)
  Use Canonical Models to set context window sizes (#6723)
  Set up direnv and update flake inputs (#6526)
  fix: restore subagent tool call notifications after summon refactor (#7243)
  fix(ui): preserve server config values on partial provider config save (#7248)
  fix(claude-code): allow goose to run inside a Claude Code session (#7232)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@DOsinga DOsinga DOsinga approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

OpenAI API Host falls back to default when saving other fields

2 participants

@clayarnoldg2m @DOsinga

Comments