docs: add ACP providers guide for claude-acp and codex-acp#7800
docs: add ACP providers guide for claude-acp and codex-acp#7800codefromthecrypt merged 1 commit intomainfrom
Conversation
Signed-off-by: Adrian Cole <adrian@tetrate.io>
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 94166a9015
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| | Mode | Session Mode | Behavior | | ||
| |-----------------|---------------------|-------------------------------------------------------| | ||
| | `auto` | `bypassPermissions` | Skips all permission checks | | ||
| | `smart-approve` | `acceptEdits` | Auto-accepts file edits, prompts for risky operations | |
There was a problem hiding this comment.
This table documents smart-approve as a valid GOOSE_MODE value, but goose parses GooseMode in snake_case (smart_approve in crates/goose/src/config/goose_mode.rs), so copying this value causes parsing to fail; both ACP providers then fall back with config.get_goose_mode().unwrap_or(GooseMode::Auto), which can unintentionally switch users into auto mode with much looser approvals. Please document smart_approve here (and in the matching Codex ACP table) to avoid unsafe misconfiguration.
Useful? React with 👍 / 👎.
2 participants
Summary
Documents the
claude-acpandcodex-acpproviders added in #6605. New ACP Providers guide covers setup, configuration, permission modes, and extension passthrough. Adds ACP section to the providers reference page with table entries and links.Type of Change
AI Assistance
Testing
Verified all external links and binary/package names against source (
claude_acp.rs,codex_acp.rs,providers.rs).Related Issues
Docs from #6605