fix: avoid word splitting by space for windows shell commands (#7781)

[0xfk0]

The problem: when running shell-commands on Windows, Goose splits command to words by spaces and when passes every word as a separate argument to command interpreter (cmd.exe).

For example, when model tries to call a command: find /I "word1 word2" *.txt this command passed to command interpreter as (each line is a separate argument):

• cmd.exe
• /C
• find
• /I
• "word1
• word2"
• *.txt

Command interpreter (cmd.exe) just passes discrete arguments as is to find program. So instead of one argument find program accepts a string which is split into two argument. This causes following errors.

Generally, this bug prevents using Goose on Windows (majority of commmands issued by the model include double quotes). Due to this bug model cannot use PowerShell, cannot use quoted file names, etc...

The root cause of the issue is with how command line is constructed:

let mut command = tokio::process::Command::new("cmd");
command.arg("/C").arg(command_line);

Even though command_line is passed as a single argument, if it contains spaces and quotes, the way Windows processes command line arguments can still cause issues with quote parsing.

Solution:

here's a Windows-specific method in tokio:process::Command called raw_arg:

raw_arg Available on Windows only.
Append literal text to the command line without any quoting or escaping.
This is useful for passing arguments to cmd.exe /c, which doesn't follow
CommandLineToArgvW escaping rules.

Now command line arguments for example shown above looks as:

• cmd.exe
• /C
• find /I "word1 word2" *.txt

Issue fixed.

Summary

Type of Change

• Feature
• Bug fix
• Refactor / Code quality
• Performance improvement
• Documentation
• Tests
• Security fix
• Build / Release
• Other (specify below)

AI Assistance

• This PR was created or reviewed with AI assistance

Testing

Related Issues

Relates to #ISSUE_ID
Discussion: LINK (if any)

Screenshots/Demos (for UX changes)

Before:

After:

[DOsinga]

thanks!