feat: ability to expand sidebar to see chats names by Abhijay007 · Pull Request #7816 · block/goose

Abhijay007 · 2026-03-11T19:52:34Z

closes : #7791

Summary

Type of Change

Feature

AI Assistance

This PR was created or reviewed with AI assistance

Testing

Tested on desktop app

Screenshots/Demos (for UX changes)

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 355d148484

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

ui/desktop/src/components/Layout/AppLayout.tsx

DOsinga

can you use the settings.json to store this? we're trying to move away from localstorage

Abhijay007 · 2026-03-11T20:04:57Z

Persist nav width after drag, not on every mousemove

Writing localStorage inside onMouseMove makes each pointer event perform a synchronous storage write, which blocks the UI thread and can make resize dragging noticeably janky on slower machines or busy render cycles. Keeping the width in React state during the drag and committing to storage in onMouseUp avoids this per-frame blocking while preserving persistence.

Useful? React with 👍 / 👎.

let me look into this

Abhijay007 · 2026-03-11T20:23:07Z

@DOsinga updated it to use settings.json to store

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0ccc9cb554

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

ui/desktop/src/components/Layout/AppLayout.tsx

DOsinga

on second thought, I'm wondering whether we should persist this at all.

consider CSS resize: horizontal on the nav panel (with min-width/max-width constraints) instead of manual mousedown/mousemove/mouseup tracking — it gives you native drag-to-resize with near-zero JS

it would be smoother, less code and yeah, might upset some people, but fixes the basic problem. what do you think?

ui/desktop/src/utils/settings.ts

DOsinga · 2026-03-12T16:42:31Z

also what codex says

Abhijay007 · 2026-03-13T12:53:53Z

on second thought, I'm wondering whether we should persist this at all.

consider CSS resize: horizontal on the nav panel (with min-width/max-width constraints) instead of manual mousedown/mousemove/mouseup tracking — it gives you native drag-to-resize with near-zero JS

it would be smoother, less code and yeah, might upset some people, but fixes the basic problem. what do you think?

I deleted this by mistake:

orginal comments I poseted : Hi @DOsinga I looked into this and the thing is the nav panel needs overflow-visible in condensed mode for the hover controls, but resize: horizontal requires overflow: hidden/auto/scroll those two are incompatible. There's also a conflict with framer-motion's JS-controlled width animation, I am not sure if I am I'm missing smth here, but the manual approach seems necessary here.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2d104dd46e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

ui/desktop/src/components/Layout/AppLayout.tsx

Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>

Signed-off-by: Abhijay Jain <Abhijay007j@gmail.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 80ecf05817

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-17T18:21:26Z

ui/desktop/src/components/Layout/AppLayout.tsx

+      document.body.style.cursor = 'col-resize';
+      document.body.style.userSelect = 'none';
+      window.addEventListener('mousemove', onMouseMove);
+      window.addEventListener('mouseup', onMouseUp);


Cancel sidebar drag when pointer leaves the window

The drag lifecycle only ends on window's mouseup, so if the user starts resizing and releases the mouse outside the app window, cleanup never runs: dragStateRef stays set, userSelect/cursor overrides remain, and moving the mouse back over the app can keep resizing unexpectedly until another in-window mouseup happens. This is a user-visible interaction regression for common edge-drags and should be handled by also terminating drag on window blur/leave (or by using pointer capture).

Useful? React with 👍 / 👎.

@jh-block these are edge cases I think we can skip it for now

Signed-off-by: Abhijay007 <Abhijay007j@gmail.com> Signed-off-by: Abhijay Jain <Abhijay007j@gmail.com> Signed-off-by: esnyder <elijah.snyder1@gmail.com>

Abhijay007 requested a review from alexhancock March 11, 2026 19:52

Abhijay007 changed the title ~~Feat/expand chat~~ feat: ability to expand sidebar to see chats names Mar 11, 2026

chatgpt-codex-connector bot reviewed Mar 11, 2026

View reviewed changes

ui/desktop/src/components/Layout/AppLayout.tsx Outdated Show resolved Hide resolved

ui/desktop/src/components/Layout/AppLayout.tsx Show resolved Hide resolved

DOsinga approved these changes Mar 11, 2026

View reviewed changes

Abhijay007 requested a review from DOsinga March 11, 2026 20:21

chatgpt-codex-connector bot reviewed Mar 11, 2026

View reviewed changes

ui/desktop/src/components/Layout/AppLayout.tsx Outdated Show resolved Hide resolved

jh-block self-assigned this Mar 12, 2026

DOsinga approved these changes Mar 12, 2026

View reviewed changes

ui/desktop/src/utils/settings.ts Show resolved Hide resolved

Abhijay007 force-pushed the feat/expandChat branch from f444276 to 2d104dd Compare March 13, 2026 12:49

Abhijay007 requested a review from DOsinga March 13, 2026 12:54

chatgpt-codex-connector bot reviewed Mar 13, 2026

View reviewed changes

ui/desktop/src/components/Layout/AppLayout.tsx Outdated Show resolved Hide resolved

Abhijay007 added 6 commits March 17, 2026 23:19

feat: ability to expand sidebar to see chats names

ffd1ed8

Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>

refactor: make it expandable from right side too

e16cc39

Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>

refactor: use setting.json instead of local storage

a38fa35

Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>

refactor: fix test build

0714369

Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>

refactor: store delta from the default instead of absolute width

e2550bb

Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>

fix : zero delta as a persisted nav width

80ecf05

Signed-off-by: Abhijay Jain <Abhijay007j@gmail.com>

Abhijay007 force-pushed the feat/expandChat branch from 2d104dd to 80ecf05 Compare March 17, 2026 18:15

Abhijay007 requested a review from jh-block March 17, 2026 18:17

chatgpt-codex-connector bot reviewed Mar 17, 2026

View reviewed changes

DOsinga added this pull request to the merge queue Mar 20, 2026

Merged via the queue into block:main with commit 387f124 Mar 20, 2026
20 checks passed

Conversation

Abhijay007 commented Mar 11, 2026

Summary

Type of Change

AI Assistance

Testing

Screenshots/Demos (for UX changes)

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

DOsinga left a comment

Choose a reason for hiding this comment

Uh oh!

Abhijay007 commented Mar 11, 2026

Uh oh!

Abhijay007 commented Mar 11, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

DOsinga left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DOsinga commented Mar 12, 2026

Uh oh!

Abhijay007 commented Mar 13, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

Abhijay007 Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants