fix: disable some computercontroller functionality when no $DISPLAY detected#7824
Merged
codefromthecrypt merged 1 commit intomainfrom Mar 12, 2026
Merged
Conversation
codefromthecrypt
approved these changes
Mar 12, 2026
Collaborator
codefromthecrypt
left a comment
codefromthecrypt
left a comment
There was a problem hiding this comment.
Docker is naturally headless so went with that to verify
Before (computer_control):
$ npx @modelcontextprotocol/inspector --cli --method tools/list docker run --rm -i ghcr.io/block/goose:latest mcp computercontroller 2>/dev/null | jq '[.tools[].name]'
[
"automation_script",
"cache",
"computer_control",
"docx_tool",
"pdf_tool",
"web_scrape",
"xlsx_tool"
]After (no computer_control):
$ npx @modelcontextprotocol/inspector --cli --method tools/list docker run --rm -i goose:pr-7824 mcp computercontroller 2>/dev/null | jq '[.tools[].name]'
[
"automation_script",
"cache",
"docx_tool",
"pdf_tool",
"web_scrape",
"xlsx_tool"
]
michaelneale
added a commit
that referenced
this pull request
Mar 15, 2026
* origin/main: Remove include from Cargo.toml in goose-mcp (#7838) Exit agent loop when tool call JSON fails to parse (#7840) chore: remove redundant husky prepare script (#7829) Add github actions workflow for unused deps (#7681) fix: prevent SSE connection drops from silently truncating responses (#7831) doc: Added notes in contribution guide for pnpm (#7833) add prefer-offline to pnpm config to skip unnecessary registry lookups (#7828) fix: remove dead read handler from DeveloperClient (#7821) fix: prevent SageMaker TGI from being marked configured when only Bedrock keys are set (#7284) fix: disable some computercontroller functionality when no $DISPLAY detected (#7824) test(acp): align provider and server test parity (#7822) fix(acp): register MCP extensions when resuming a session (#7806) # Conflicts: # ui/desktop/src/hooks/useChatStream.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6797
Problem: On headless Linux (no
$DISPLAYor$WAYLAND_DISPLAY), thecomputercontrollerextension printsWarning: Failed to initialize Linux automation: Unable to detect display serverevery time goose runs, even though the user has no display and doesn't need display-dependent tools.Root cause:
LinuxAutomation::new()unconditionally callsinitialize(), which fails when no display server is detected and prints a warning viaeprintln!.