Skip to content

refactor: remove top-level chat tabs#70

Merged
matt2e merged 2 commits intomainfrom
remove-tabs
Apr 2, 2026
Merged

refactor: remove top-level chat tabs#70
matt2e merged 2 commits intomainfrom
remove-tabs

Conversation

@matt2e
Copy link
Copy Markdown
Collaborator

@matt2e matt2e commented Apr 2, 2026

Summary

  • remove the top-level tab bar and use a single active chat session model
  • simplify session state and startup by deleting persisted tab UI state
  • update sidebar flows, tests, and the system command wiring to match the new navigation model

Replace tab-based navigation with a single active session flow in the app shell and sidebar. Remove the persisted ui_state save/load path from the frontend and Tauri backend, keeping only the unrelated home-directory command in a dedicated system command module. Update affected tests and fixtures to match the new session-only model.
@matt2e matt2e requested a review from wesbillman as a code owner April 2, 2026 00:23
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 37fff37f70

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

onHomeClick={() => handleNavigate("home")}
/>

<div className="flex flex-1 min-h-0 overflow-hidden">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore titlebar offset after removing top tab strip

The new layout renders the app body starting at the very top (AppShell now goes straight into the main flex row), but the Tauri window is still configured with an overlay/hidden title bar and macOS traffic lights (src-tauri/tauri.conf.json), so there is no longer a dedicated top gutter/offset to keep native controls clear of app UI. In practice on macOS this causes the traffic-light controls to overlap the sidebar header area and reduces reliable drag space; please add a replacement top drag/offset region (equivalent to the previous pl-20 handling) when the tab bar is removed.

Useful? React with 👍 / 👎.

@matt2e matt2e merged commit 50e7548 into main Apr 2, 2026
7 checks passed
@matt2e matt2e deleted the remove-tabs branch April 2, 2026 01:00
tellaho added a commit to tellaho/goose2 that referenced this pull request Apr 2, 2026
Merge origin/main (tabs removal refactor block#70) and fix two code review items:
- Register @tailwindcss/typography plugin via @plugin directive for prose classes
- Fix accordion keyframes to use --radix-accordion-content-height (not --bits-)
- Remove GooseIcon home button from sidebar header (removed upstream)
- Adopt tab→session rename throughout sidebar components

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant