fix: update E2E tests for Radix dialog changes#87
Merged
wesbillman merged 1 commit intomainfrom Apr 2, 2026
Merged
Conversation
The Tailwind v4 upgrade (#85) replaced dialog components with Radix UI primitives that use aria-labelledby instead of aria-label. Update E2E tests to check DialogTitle h2 text instead of missing aria-label attrs, and use getByRole("button", { name: "Close" }) for the X close button. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skills.spec.tsandpersonas.spec.tsbroken by the Tailwind v4 / boss-ui upgrade (feat: import boss-ui components + Tailwind v4 upgrade #85)aria-labelassertions withDialogTitleh2 text checks (new Radix dialogs usearia-labelledbyinstead ofaria-label)getByLabel("Close")withgetByRole("button", { name: "Close" })for the X close buttonTest plan
🤖 Generated with Claude Code