feat: replace hook symlinks with shell wrapper scripts#9
Merged
alecthomas merged 1 commit intomainfrom Mar 17, 2026
Merged
Conversation
Instead of symlinking hook names to the lhm binary and detecting the hook from argv[0], write shell scripts that invoke 'lhm run-hook <name>'. This makes hook identity independent of filename, so other tools that rename hooks in hooksPath no longer break dispatch. - Add 'run-hook' subcommand that takes hook name explicitly - Replace create_hook_symlinks with create_hook_scripts - Remove file before writing to avoid writing through existing symlinks - Remove legacy argv[0]-based hook detection and invoked_name() - Update README to describe new mechanism
alecthomas
force-pushed
the
hook-wrapper-scripts
branch
from
78cc6c1 to
2780935
Compare
alecthomas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of symlinking hook names to the lhm binary and detecting the
hook from argv[0], write shell scripts that invoke 'lhm run-hook '.
This makes hook identity independent of filename, so other tools that
rename hooks in hooksPath no longer break dispatch.