Skip to content

feat(tel): include version in telemetry output#66

Merged
illegalprime merged 1 commit into
mainfrom
eden/tel.version
Apr 23, 2026
Merged

feat(tel): include version in telemetry output#66
illegalprime merged 1 commit into
mainfrom
eden/tel.version

Conversation

@illegalprime
Copy link
Copy Markdown
Contributor

Follow up from comments on #10

@illegalprime illegalprime requested a review from a team as a code owner April 23, 2026 15:12
@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@github-actions
Copy link
Copy Markdown

🔐 Codex Security Review

Note: This is an automated security-focused code review generated by Codex.
It should be used as a supplementary check alongside human review.
False positives are possible - use your judgment.

Scope summary

  • Reviewed pull request diff only (973548c5c8b3d5e4cf7c49acc9e94dd763082b43...c267ce87104938abb6fe1b450c6941551d1e8810, exact PR three-dot diff)
  • Model: gpt-5.4

💡 Click "edited" above to see previous reviews for this PR.


Review Summary

Overall Risk: NONE

Findings

No concrete security, correctness, or reliability issues found in the scoped diff.

Notes

  • The diff is narrowly scoped to telemetry initialization: it threads the existing build-time version string into fleet_telemetry.Setup(...) and adds OpenTelemetry service.version metadata to the tracer resource.
  • I verified the new Setup signature has a single in-repo call site and that it was updated consistently, so I did not find a compile-time or startup-path mismatch in the changed code.
  • The patch does not modify authz/authn flow, SQL/query construction, RPC validation, shell execution, plugin trust boundaries, network discovery, frontend token handling, infrastructure config, or any mining pool / wallet / stratum configuration path.
  • I could not run go test or a build in this environment because the sandbox is fully read-only and blocks Go module/build cache creation, so this review is based on static analysis of .git/codex-review.diff and the surrounding changed code only.

Generated by Codex Security Review |
Triggered by: @illegalprime |
Review workflow run

@illegalprime illegalprime changed the title feat: include version in telemetry output feat(tel): include version in telemetry output Apr 23, 2026
@illegalprime illegalprime merged commit 6a72c3b into main Apr 23, 2026
62 checks passed
@illegalprime illegalprime deleted the eden/tel.version branch April 23, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants