Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6f55b17ef1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: Claude Code <noreply@anthropic.com> Ai-assisted: true
Co-authored-by: Claude Code <noreply@anthropic.com> Ai-assisted: true
afollestad
force-pushed
the
af/update-release-process
branch
from
6f55b17 to
b3240fe
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| -f artifact_url=https://github.com/block/qrgo/releases/download/${{ github.ref_name }}/qrgo-release.tar.gz \ | ||
| -f sha256=${{ steps.generate_hash.outputs.file_hash }} | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} No newline at end of file |
There was a problem hiding this comment.
The gh workflow run --repo block/homebrew-tap call is authenticated with secrets.GITHUB_TOKEN, which is scoped to this repository and typically cannot trigger workflows in a different repo. Use a dedicated secret (PAT or GitHub App token) that has permission to run workflows in block/homebrew-tap, and pass that token to gh for this step.
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |
| GITHUB_TOKEN: ${{ secrets.HOMEBREW_TAP_WORKFLOW_TOKEN }} |
There was a problem hiding this comment.
This is likely true as it was before - not yet sure how to fix this though
There was a problem hiding this comment.
Yep, it's still true. To fix it, we'll need to set up organization secrets:
- Homebrew Tap Github App and
- a private key
and then add these secrets to each repo. We should be able to copy what our internal tap uses, but I don't have permission to see that.
If you'd like to fix this yourself, I can add you as a homebrew-tap maintainer and you can post in the internal #open-source channel.
There was a problem hiding this comment.
@tcmulcahy I think I already have access to homebrew-tap; just asked in #opensource about getting a shared app/secret
…for latest instructions in block/homebrew-tap.