Upgrade Compose to 1.0.0-alpha09.#117
Conversation
zach-klippenstein
force-pushed
the
zachklipp/upgrade-compose
branch
from
2fc0ce2 to
d424c74
Compare
zach-klippenstein
changed the title
zach-klippenstein
requested review from
a team,
jamesmosley55 and
pyricau
as code owners
| * `~/.gradle/gradle.properties` file. | ||
| */ | ||
| val KotlinCompiler = System.getProperty("square.kotlinVersion") ?: "1.4.10" | ||
| val KotlinCompiler = System.getProperty("square.kotlinVersion") ?: "1.4.21" |
There was a problem hiding this comment.
Latest compose version requires this kotlin version.
|
|
||
| @Test fun when_includingPii_then_hierarchyContainsText() { | ||
| composeRule.setContentWithExplicitRoot { | ||
| Text("FooBar") |
There was a problem hiding this comment.
Text is now material-specific.
| LazyColumnFor(items = listOf(1, 2, 3), modifier = Modifier.testTag("list")) { | ||
| Box(Modifier.testTag("child:$it")) | ||
| if (it % 2 == 0) { | ||
| Box(Modifier.testTag("child:$it (even)")) | ||
| LazyColumn(Modifier.testTag("list")) { | ||
| items(listOf(1, 2, 3)) { | ||
| Box(Modifier.testTag("child:$it")) | ||
| if (it % 2 == 0) { | ||
| Box(Modifier.testTag("child:$it (even)")) | ||
| } |
There was a problem hiding this comment.
Our code style changed, probably want to do an indentation pass over the whole codebase.
| SubcomposeLayout<Unit>(modifier) { constraints -> | ||
| SubcomposeLayout(modifier) { constraints -> |
There was a problem hiding this comment.
This isn't being suddenly inferred, the type parameter was actually removed.
| kotlinCompilerExtensionVersion = Versions.Compose | ||
| } | ||
|
|
||
| packagingOptions { |
There was a problem hiding this comment.
Could you add a comment about why this is needed?
There was a problem hiding this comment.
It's the same reason it's always needed for most kotlin libraries, I can link to more info but it's pretty standard. It's also already used in other modules in this library.
zach-klippenstein
force-pushed
the
zachklipp/upgrade-compose
branch
2 times, most recently
from
6e8bffc to
a3457f4
Compare
|
The build is failing because the GitHub workflow overrides the kotlin version to an old one: https://github.com/square/radiography/blob/2e0dff64cf4b9a4ea3bd559f9f800ba18628902b/.github/workflows/android.yml#L15 @pyricau do you remember why that's there? I think we should remove it. Update: I think it's vestigial from when we were trying to build both 1.4 and 1.3 in CI. I'll remove it. |
zach-klippenstein
force-pushed
the
zachklipp/upgrade-compose
branch
2 times, most recently
from
b418ea2 to
ef8ea37
Compare
zach-klippenstein
force-pushed
the
zachklipp/upgrade-compose
branch
from
ef8ea37 to
1e415fc
Compare
2 participants
No description provided.