Skip to content

Upgrade Compose to beta01.#128

Merged
zach-klippenstein merged 2 commits intomainfrom
zachklipp/compose-beta
Mar 1, 2021
Merged

Upgrade Compose to beta01.#128
zach-klippenstein merged 2 commits intomainfrom
zachklipp/compose-beta

Conversation

@zach-klippenstein
Copy link
Copy Markdown
Collaborator

@zach-klippenstein zach-klippenstein commented Feb 28, 2021

There were some actual changes required to this – most notably:

  • The way that Android views are embedded in compositions changed quite a bit so that required some rewriting.
  • CompositionReference was renamed to CompositionContext, so I renamed our related definitions to match.
  • TextFields now report their text via the EditableText property, the Text property is reserved for non-editable text. There were also a lot more semantic properties added, so we now report all of those.

This PR updates the unsupported-version test to Compose alpha12, which means we will probably report something at vaguely useful from that version, but not necessarily any earlier. Compose being in beta means that it is now API-stable, which means that we should be able to continue to support much earlier versions of compose much longer – we just have to internally be aware if different Compose-internal implementation details change. So far we usually end up having to bump the minimum version almost every release because it was just too much work to support internal differences and API differences.

Base automatically changed from zachklipp/upgrade-agp to main February 28, 2021 17:55
@zach-klippenstein zach-klippenstein force-pushed the zachklipp/compose-beta branch 2 times, most recently from 172e2cb to 17821e0 Compare March 1, 2021 19:20
@zach-klippenstein zach-klippenstein changed the title WIP Upgrade Compose to beta01. Upgrade Compose to beta01. Mar 1, 2021
@zach-klippenstein zach-klippenstein marked this pull request as ready for review March 1, 2021 19:21
@zach-klippenstein
Copy link
Copy Markdown
Collaborator Author

zach-klippenstein commented Mar 1, 2021

This is the second time in a row these tests failed - previously on a PR that didn't change any code. Either they're flaky, or some infra broke recently:


radiography.test.RadiographyUiTest > when_showDialog_then_hierarchyHasTwoWindows[test(AVD) - 11] FAILED 
529
	expected to be true
530
	at radiography.test.RadiographyUiTest.waitForFocus(RadiographyUiTest.kt:142)
531

532
radiography.test.RadiographyUiTest > when_onlyFocusedWindow_then_hierarchyHasOnlyDialog[test(AVD) - 11] FAILED 
533
	expected to be true
534
	at radiography.test.RadiographyUiTest.waitForFocus(RadiographyUiTest.kt:142)
535

Update: filed #130

@zach-klippenstein zach-klippenstein changed the base branch from main to zachklipp/disable-30 March 1, 2021 22:41
Base automatically changed from zachklipp/disable-30 to main March 1, 2021 23:10
@zach-klippenstein zach-klippenstein merged commit 4ddf545 into main Mar 1, 2021
@zach-klippenstein zach-klippenstein deleted the zachklipp/compose-beta branch March 1, 2021 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants