Merged
Conversation
172e2cb to
17821e0
Compare
17821e0 to
00431e8
Compare
pyricau
approved these changes
Mar 1, 2021
Collaborator
Author
|
This is the second time in a row these tests failed - previously on a PR that didn't change any code. Either they're flaky, or some infra broke recently: Update: filed #130 |
00431e8 to
61564ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some actual changes required to this – most notably:
CompositionReferencewas renamed toCompositionContext, so I renamed our related definitions to match.TextFields now report their text via theEditableTextproperty, theTextproperty is reserved for non-editable text. There were also a lot more semantic properties added, so we now report all of those.This PR updates the unsupported-version test to Compose alpha12, which means we will probably report something at vaguely useful from that version, but not necessarily any earlier. Compose being in beta means that it is now API-stable, which means that we should be able to continue to support much earlier versions of compose much longer – we just have to internally be aware if different Compose-internal implementation details change. So far we usually end up having to bump the minimum version almost every release because it was just too much work to support internal differences and API differences.