Conversation
androiddevnotes
requested review from
a team,
jamesmosley55 and
pyricau
as code owners
|
|
zach-klippenstein
left a comment
zach-klippenstein
left a comment
There was a problem hiding this comment.
These sound less grammatical to me, can you elaborate?
For both the corrections, I used Grammarly’s browser extension which makes grammar suggestions and personally the corrected sentences sound better to me as well. |
| To create a custom renderer for Compose, implement a `ViewStateRenderer` to handle the values of type | ||
| `ComposeView`. However, since Radiography gets most of its information about composables from their | ||
| semantics properties, in most cases you shouldn't need to define any custom rendering logic. The | ||
| semantics properties, in most cases you shouldn't need to define any custom rendering logic. |
There was a problem hiding this comment.
I didn't use an article initially because this sentence is saying more than the ComposeView type has properties, but I think that's wrong because in the context of the rest of the paragraph, this sentence is talking about implementations of ViewRender, and in the context of a particular implementation, it makes more sense to talk about instance vs type. However, I think it's better to use a plural here to match above plural "values if type ComposeView", for consistency. Does that make sense?
As per code reviewer suggestions, reverted `the values` to the original `values`.
|
UI test timed out, but this is just a docs change so I'm gonna merge anyway. |
4 participants
No description provided.