Sort skip ids before using in binary search#94
Merged
zach-klippenstein merged 1 commit intoblock:mainfrom Sep 8, 2020
Merged
Conversation
samruston
requested review from
a team,
jamesmosley55 and
pyricau
as code owners
|
|
steve-the-edwards
approved these changes
Sep 8, 2020
zach-klippenstein
approved these changes
Sep 8, 2020
Collaborator
zach-klippenstein
left a comment
zach-klippenstein
left a comment
There was a problem hiding this comment.
Thanks for doing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skipIdsViewFilteris using a binary search without making sure the view ids are sorted. This PR simply sorts it when creating the view filter. Added a test that previously failed because the list is unsorted.