Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds package-level documentation for pkg/statement, describing how Spirit parses and analyzes DDL (via TiDB parser), including safety checks and CREATE TABLE structural parsing helpers.
Changes:
- Added
pkg/statement/README.mddocumenting core statement parsing APIs and safety analysis helpers. - Documented CREATE TABLE structured parsing types (columns, indexes, constraints, partitions) and helper functions for index deferral/restore workflows.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
aparajon
reviewed
Feb 2, 2026
| ## Limitations | ||
|
|
||
| 1. **Functional Indexes**: `CREATE INDEX` with functional expressions cannot be converted to `ALTER TABLE` | ||
| 2. **Single Schema**: Multi-table operations must use the same schema |
Collaborator
There was a problem hiding this comment.
Would this return an error?
aparajon
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Pull Request should be associated with an Issue.